Date: Fri, 2 Sep 2011 07:23:16 +0200 From: Robert Millan <rmh@debian.org> To: John Baldwin <jhb@freebsd.org> Cc: freebsd-current@freebsd.org Subject: Re: [PATCH] Fix NKPT kernel config option Message-ID: <CAOfDtXMy%2B8pmNhRODwmutXUtrbmYgv-0cwdF8dR_AkkM=uQf4g@mail.gmail.com> In-Reply-To: <201109011728.13979.jhb@freebsd.org> References: <CAOfDtXPDAyeZX7adW5Hixa2XwyOFgic=FRU6ipUHZcY15JVQaQ@mail.gmail.com> <201109011728.13979.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2011/9/1 John Baldwin <jhb@freebsd.org>: > In general we force the relevant C files to use opt_*.h includes and avoid > nested includes of those in headers. With this approach I can't trust that this feature will do the right thing. I would rather modify pmap.h by hand than run the unnecessary risk. > Do you know of any C files that do > are using NKPT (or values derived from it) without including opt_pmap.h? Many. To obtain a full list, I suggest you put something like: #ifdef NKPT #warning nkpt:good #else #warning nkpt:bad #endif in pmap.h and build with "WERROR=" -- Robert Millan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfDtXMy%2B8pmNhRODwmutXUtrbmYgv-0cwdF8dR_AkkM=uQf4g>