Date: Sun, 19 May 2002 18:40:08 -0700 (PDT) From: Jonathan Mini <mini@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 11577 for review Message-ID: <200205200140.g4K1e8f67066@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://people.freebsd.org/~peter/p4db/chv.cgi?CH=11577 Change 11577 by mini@mini_stylus on 2002/05/19 18:39:33 Comment and whitespace fixups. Affected files ... ... //depot/projects/kse/sys/i386/i386/vm_machdep.c#41 edit Differences ... ==== //depot/projects/kse/sys/i386/i386/vm_machdep.c#41 (text+ko) ==== @@ -279,7 +279,7 @@ * before freeing them? (not done here) */ kmem_free(kernel_map, (vm_offset_t)pcb->pcb_ext, - ctob(IOPAGES + 1)); + ctob(IOPAGES + 1)); pcb->pcb_ext = 0; } if (pcb->pcb_flags & PCB_DBREGS) { @@ -294,10 +294,10 @@ void cpu_thread_setup(struct thread *td) { + td->td_pcb = (struct pcb *)(td->td_kstack + KSTACK_PAGES * PAGE_SIZE) - 1; td->td_frame = (struct trapframe *)((caddr_t)td->td_pcb - 16) - 1; - } struct md_store { @@ -309,16 +309,16 @@ cpu_save_upcall(struct thread *td, struct kse *newkse) { - /* Point the pcb to the top of the stack */ + /* Point the pcb to the top of the stack. */ newkse->ke_mdstorage = malloc(sizeof(struct md_store), M_TEMP, M_WAITOK); - /* note: use of M_WAITOK means it will not fail */ + /* Note: use of M_WAITOK means it won't fail. */ newkse->ke_pcb = &(((struct md_store *)(newkse->ke_mdstorage))->mds_pcb); newkse->ke_frame = &(((struct md_store *)(newkse->ke_mdstorage))->mds_frame); - /* Copy the upcall pcb . Kernel mode & fp regs are here.*/ + /* Copy the upcall pcb. Kernel mode & fp regs are here. */ bcopy(td->td_pcb, newkse->ke_pcb, sizeof(struct pcb)); /* This copies most of the user mode register values. */ @@ -332,19 +332,19 @@ td->td_flags |= TDF_UPCALLING; - /* Point the pcb to the top of the stack */ + /* Point the pcb to the top of the stack. */ pcb2 = td->td_pcb; /* - * Copy the upcall pcb. This loads kernel regs. - * those not loaded individually below get their default - * valuse here. - * XXXKSE I think it might be an idea - * to simply skip this as I think the values - * of the other registers may be unimportant. + * Copy the upcall pcb. This loads kernel regs. + * Those not loaded individually below get their default + * values here. + * + * XXXKSE It might be a good idea to simply skip this as + * the values of the other registers may be unimportant. * This would remove any requirement for knowing the KSE - * at this time. (see the matching comment below for - * more analysis). (need a good safe default) + * at this time (see the matching comment below for + * more analysis) (need a good safe default). */ bcopy(pcb, pcb2, sizeof(*pcb2)); @@ -353,7 +353,7 @@ * The -16 is so we can expand the trapframe if we go to vm86. * Don't forget to set this stack value into whatever supplies * the address for the fault handlers. - * The contects are filled in at the time we actually DO the + * The contexts are filled in at the time we actually DO the * upcall as only then do we know which KSE we got. */ td->td_frame = (struct trapframe *)((caddr_t)pcb2 - 16) - 1; @@ -375,7 +375,7 @@ * pcb2->pcb_savefpu: cloned above. * pcb2->pcb_flags: cloned above. * pcb2->pcb_onfault: cloned above (always NULL here?). - * pcb2->pcb_gs: cloned above. XXXKSE ??? + * pcb2->pcb_gs: cloned above. XXXKSE ??? * pcb2->pcb_ext: cleared below. */ pcb2->pcb_ext = NULL; To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200205200140.g4K1e8f67066>