Date: Thu, 13 Jan 2005 14:47:13 +0000 From: Brian Somers <brian@FreeBSD.org> To: Robert Watson <rwatson@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/nfsclient nfs_diskless.c Message-ID: <20050113144713.563dcb27@dev.lan.Awfulhak.org> In-Reply-To: <Pine.NEB.3.96L.1050112175118.47006B-100000@fledge.watson.org> References: <200501121242.j0CCgldA068546@repoman.freebsd.org> <Pine.NEB.3.96L.1050112175118.47006B-100000@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 12 Jan 2005 17:51:56 +0000 (GMT), Robert Watson <rwatson@FreeBSD.org> wrote: > > On Wed, 12 Jan 2005, Brian Somers wrote: > > > brian 2005-01-12 12:42:46 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/nfsclient nfs_diskless.c > > Log: > > Include opt_bootp.h for BOOTP_NFSROOT > > > > PR: 73183 > > Submitted by: Darrin Smith sdar at salseast dot org > > MFC after: 7 days > > I saw this PR but decided not to pick it up because I didn't immediately > have time to test the impact on PXEbooting GENERIC kernels with NFS roots? > Have you had a chance to test that configuration? > > Robert N M Watson My rationale was that bootp_nfsroot() is undefined when BOOTP_NFSROOT is configured and must result in a build failure. As BOOTP_NFSROOT is not defined for GENERIC, the change doesn't affect the GENERIC build. I've PXE booted a generic (albiet RELENG_5) kernel that includes the change and observed no differences. -- Brian Somers <brian@Awfulhak.org> Don't _EVER_ lose your sense of humour ! <brian@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050113144713.563dcb27>