Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 9 Nov 2015 17:17:52 -0200
From:      Renato Botelho <garga@FreeBSD.org>
To:        Bryan Drewery <bdrewery@FreeBSD.org>
Cc:        Adrian Chadd <adrian@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r290612 - in head/sys: contrib/dev/ath/ath_hal/ar9300 dev/ath dev/ath/ath_hal dev/ath/ath_hal/ar5210 dev/ath/ath_hal/ar5211 dev/ath/ath_hal/ar5212 dev/ath/ath_hal/ar5312 dev/ath/ath_hal...
Message-ID:  <2B0092AA-AC59-489F-B250-98025676A80E@FreeBSD.org>
In-Reply-To: <5640D0A8.3010508@FreeBSD.org>
References:  <201511091559.tA9FxgB1046943@repo.freebsd.org> <5640D0A8.3010508@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--Apple-Mail=_492A18F5-E583-41B6-A135-F8BC2F11C632
Content-Type: multipart/mixed;
	boundary="Apple-Mail=_69077A75-9DDE-402D-9775-72EF63D0CEF2"


--Apple-Mail=_69077A75-9DDE-402D-9775-72EF63D0CEF2
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=windows-1252

> On Nov 9, 2015, at 14:58, Bryan Drewery <bdrewery@FreeBSD.org> wrote:
>=20
> On 11/9/2015 7:59 AM, Adrian Chadd wrote:
>> Author: adrian
>> Date: Mon Nov  9 15:59:42 2015
>> New Revision: 290612
>> URL: https://svnweb.freebsd.org/changeset/base/290612
>>=20
>> Log:
>>  ath(4): begin fleshing out a "reset type" extension to force =
cold/warn resets.
>>=20
>=20
> =
/root/git/freebsd/sys/modules/ath/../../dev/ath/ath_hal/ar5212/ar5212_rese=
t.c:120:18:
> error: type specifier missing, defaults to 'int' =
[-Werror,-Wimplicit-int]
>        HAL_RESET_TYPE, resetType,

Attached patch fixed it for me.


--Apple-Mail=_69077A75-9DDE-402D-9775-72EF63D0CEF2
Content-Disposition: attachment;
	filename=fix_ath.diff
Content-Type: application/octet-stream;
	name="fix_ath.diff"
Content-Transfer-Encoding: 7bit

Index: sys/dev/ath/ath_hal/ar5212/ar5212_reset.c
===================================================================
--- sys/dev/ath/ath_hal/ar5212/ar5212_reset.c	(revision 290615)
+++ sys/dev/ath/ath_hal/ar5212/ar5212_reset.c	(working copy)
@@ -117,7 +117,7 @@
 ar5212Reset(struct ath_hal *ah, HAL_OPMODE opmode,
 	struct ieee80211_channel *chan,
 	HAL_BOOL bChannelChange,
-	HAL_RESET_TYPE, resetType,
+	HAL_RESET_TYPE resetType,
 	HAL_STATUS *status)
 {
 #define	N(a)	(sizeof (a) / sizeof (a[0]))
Index: sys/dev/ath/ath_hal/ar5416/ar5416.h
===================================================================
--- sys/dev/ath/ath_hal/ar5416/ar5416.h	(revision 290615)
+++ sys/dev/ath/ath_hal/ar5416/ar5416.h	(working copy)
@@ -193,7 +193,7 @@
 			     const struct ieee80211_channel *);
 extern	void ar5416AniPoll(struct ath_hal *, const struct ieee80211_channel *);
 extern	void ar5416AniReset(struct ath_hal *, const struct ieee80211_channel *,
-		HAL_OPMODE, HAL_RESET_TYPE, int);
+		HAL_OPMODE, int);
 
 extern	void ar5416SetBeaconTimers(struct ath_hal *, const HAL_BEACON_TIMERS *);
 extern	void ar5416BeaconInit(struct ath_hal *ah,

--Apple-Mail=_69077A75-9DDE-402D-9775-72EF63D0CEF2
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=windows-1252


--
Renato Botelho


--Apple-Mail=_69077A75-9DDE-402D-9775-72EF63D0CEF2--

--Apple-Mail=_492A18F5-E583-41B6-A135-F8BC2F11C632
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIcBAEBCgAGBQJWQPFhAAoJEPHw56GfYleQXmgP/3xBMx0ZzqhjksjpLXus4WMX
/DItm/tMLEVOSbEh3BNBZKiriN3yWEaaJGljcY7yaHNxhDGxHRdQCscrDgqdMusi
Cs8HgLMQ9C9RdxTrIHb4enAVg8qWag+RAn88LXPo4p5o7OJBPv5buh2Xuq7DTsqf
mGA1sWxMwRGjBkhbQvlQCxvZIg1QKFShzGoxA7FOjxdx77S9/zC/IkAjExAJmP1p
Nas/TspEg0ZNbk9M9kl+cwO+sCdrKS+E72VtmiQ5laKH+UnFoHXs7TGzTUg1ipzk
fy9ITtIX795mWrATZLu7Evp14ohEmllxoIim4mFTKg9HyfPiyrL8RmV76mFnivfH
rr0jUi3cbaQ3ENO7lLSs6zZ51TGMmXPYH6+amjdexL3TpB+mCyvCq/LyChNVzY1t
i5P779PwQVLKopk1v0bwfE3NAFCQbjB1iOJJP0/CV3IJSNtIVxWECuoA0vfoyccy
H0KK0eipX712yMDRND5GByZMIOreTKn0gM2tPEOjcsyeqlJE+xO+LJYK28kIHorP
f2o3fUt3zhDJAf49P6GrTELTL3A95EFvyg8xkIEy0ppIvNGkL5tZZ7LD8/bIZmJC
O61rjKV4Bgjkt7oy18K1ksar56uuW33+2WNQ0hw02sSOxmO2ZK1lZO4xQCOpitD4
s/qh5ltugQi0whCYU5fA
=XaYO
-----END PGP SIGNATURE-----

--Apple-Mail=_492A18F5-E583-41B6-A135-F8BC2F11C632--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2B0092AA-AC59-489F-B250-98025676A80E>