Date: Tue, 20 Sep 2016 09:34:34 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Alan Somers <asomers@freebsd.org> Cc: Alexander Motin <mav@freebsd.org>, Edward Tomasz Napierala <trasz@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r305988 - in head/sys: geom sys Message-ID: <03DFBBFF-FA98-48CB-8180-B03B37538301@gmail.com> In-Reply-To: <CAOtMX2h=aX0voEKdXFpgiRN6Hgk-i_kxGRb30Q=VG25BNB_X8g@mail.gmail.com> References: <201609191746.u8JHkFKI071354@repo.freebsd.org> <CAOtMX2gSNewQK308fToOV9zTZD=icStA2=H9mqD4tjpv3pyY%2BA@mail.gmail.com> <a8de869c-4947-9d96-21bc-2c5c722ea798@FreeBSD.org> <CAOtMX2h=aX0voEKdXFpgiRN6Hgk-i_kxGRb30Q=VG25BNB_X8g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_71FB91B2-CF59-488C-BAA4-5DC1DF807AAC Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Sep 20, 2016, at 09:28, Alan Somers <asomers@freebsd.org> wrote: >=20 > On Tue, Sep 20, 2016 at 10:23 AM, Alexander Motin <mav@freebsd.org> = wrote: >> On 20.09.2016 09:20, Alan Somers wrote: >>> On Mon, Sep 19, 2016 at 11:46 AM, Edward Tomasz Napierala >>> <trasz@freebsd.org> wrote: >>>> Author: trasz >>>> Date: Mon Sep 19 17:46:15 2016 >>>> New Revision: 305988 >>>> URL: https://svnweb.freebsd.org/changeset/base/305988 >>>>=20 >>>> Log: >>>> Remove unused bio_taskqueue(). >>>>=20 >>>> MFC after: 1 month >>>>=20 >>>> Modified: >>>> head/sys/geom/geom_io.c >>>> head/sys/sys/bio.h >>>>=20 >>>=20 >>> This is a KBI change, so you should bump __FreeBSD_version. You >>> probably shouldn't MFC it, either. >>=20 >> The last/only consumer of this KPI I know gone with FreeBSD 9 and old >> ATA stack. Do you know any other? >=20 > Nothing in-tree. But it's publicly visible, so we have no way of > knowing who might be using it out-of-tree. I=E2=80=99d have to check, but this might impact us (Isilon). We don=E2=80= =99t use the __FreeBSD_version #ifdefs though in our code, so it=E2=80=99s= fine from my perspective to leave things alone. That being said, are you sure that port klds (e.g. open-vm-tools*) = aren=E2=80=99t impacted by this change? Did it go through a ports -exp = run? Thanks, -Ngie --Apple-Mail=_71FB91B2-CF59-488C-BAA4-5DC1DF807AAC Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJX4WUaAAoJEPWDqSZpMIYVuCUQAJCMvYniKW9Db2qu8Ee/Q66j 92zHotDesDrI1NiXKCVCdzOoCb28DhoH0Ov5J6C5uOJg6S3ny2cohTVDI4p4qpSg oYQ9iFHpfXCgH/1hcBI4yW0b6X7OihQTMdzkesQSUiVBYIC/47m93z/CPliKHM8R ye9WyhP9swSVnu7tpw6rpVVRJxOszD6SNAPORV6tfb0ltfUj0GeUowvkUWMtEOmr x1bbXXO1ZOVWBqFvlHiUwfGlBZ944Flo3IqCjxkc9PHh2q93ktNg51MWxAJeEMIj KO4E0lgLS6BoDaPwQW9rN6uunBBz8z6o7CwdWwF2Hx9jDft6DyEzVCrxfFssO2ov qydEFCRLhhR9hhNVobjEvReea5AQP1LYAOBiUJDIx1Vk4k9P1t03inujInkP6noI q7Xx7rQY/mEEUFfPU6CPRcPcAnXRhigdT3r9B3cIdd/WkW/wkibiMSU/G88V4mhg ztsj2Gvm6lD8d+PQAjEJs2kBIBaiSd/5F4pi1lUyAiOhvoVO4XVucXb+18g0Ny0R iVIkm8WA4GDnjtaR8Wrbg0hNlFe9VRZ1M0q9jzhtRsBH+AGqCEO1VDFpPoYAU1Ge FxmLBS38kMiC4XjC31sSrsBa/bs6uuWCDzd/HW7Ma2+/TMr67+ocxXeSd+3LAt5v Qmnm33V8F6DUiU4+gWvZ =WyjU -----END PGP SIGNATURE----- --Apple-Mail=_71FB91B2-CF59-488C-BAA4-5DC1DF807AAC--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?03DFBBFF-FA98-48CB-8180-B03B37538301>