Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 19 May 2003 14:53:40 +0300
From:      Ruslan Ermilov <ru@FreeBSD.org>
To:        Joerg Wunsch <joerg_wunsch@uriah.heep.sax.de>
Cc:        ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/devel/avr-libc Makefile
Message-ID:  <20030519115339.GI17366@sunbay.com>
In-Reply-To: <20030519114332.GG17366@sunbay.com>
References:  <200305190828.h4J8S8l0069634@repoman.freebsd.org> <20030519094115.GC1035@sunbay.com> <20030519115435.C2937@uriah.heep.sax.de> <20030519104604.GB17366@sunbay.com> <20030519125334.D2937@uriah.heep.sax.de> <20030519114332.GG17366@sunbay.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--ijf6z65S790CMqo8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

And a quick fix for the port being:

%%%
Index: Makefile
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /home/pcvs/ports/devel/avr-libc/Makefile,v
retrieving revision 1.21
diff -u -r1.21 Makefile
--- Makefile	19 May 2003 11:37:08 -0000	1.21
+++ Makefile	19 May 2003 11:50:36 -0000
@@ -33,6 +33,9 @@
 CONFIGURE_ARGS=3D	--enable-doc --disable-versioned-doc
 # Work around the braind*** introduced by <bsd.cpu.mk> in freebsd-current.
 MAKE_ENV=3D	NO_CPU_CFLAGS=3Dtrue
+# Prevent bsd.port.mk from setting CFLAGS/CXXFLAGS to unfriendly values.
+CFLAGS=3D		-O -pipe
+CXXFLAGS=3D	-O -pipe
=20
 do-build:
 		(cd ${BUILD_WRKSRC}; ${SETENV} ${MAKE_ENV} ./domake MAKE=3D${GMAKE})
%%%

Note: this is only tested with "make -n do-build".

On Mon, May 19, 2003 at 02:43:32PM +0300, Ruslan Ermilov wrote:
> On Mon, May 19, 2003 at 12:53:34PM +0200, Joerg Wunsch wrote:
> > As Ruslan Ermilov wrote:
> >=20
> > > Hm, so what's broken then?  If NO_CPU_CFLAGS is set, the effect
> > > of bsd.cpu.mk is null, if I'm reading the code correctly.  Can
> > > you please show me the actual error, as I can't find it anywhere
> > > on bento.
> >=20
> > /var/portbuild/i386/archive/errorlogs/e.5.2003051313/avr-libc-2003.05.1=
1.log
> >=20
> OK, I found the root of the problem.  It's not the port that is broken,
> nor bsd.cpu.mk (if you set NO_CPU_CFLAGS, it gives you what you have
> asked it about), but rather a bsd.port.mk that is broken, by setting
> CFLAGS to what they are.  I've edited the output slighly with fmt(1)
> to make it fit the 80-column screen, and underlined the offending
> lines:
>=20
> allmouth# make -n do-build | fmt
> (cd /CURRENT/usr/ports/devel/avr-libc/work/avr-libc-2003.05.11;
> /usr/bin/env NO_CPU_CFLAGS=3Dtrue SHELL=3D/bin/sh PORTOBJFORMAT=3Delf
>              ^^^^^^^^^^^^^^^^^^ it's okay
> PREFIX=3D/usr/local LOCALBASE=3D/usr/local X11BASE=3D/usr/X11R6
> MOTIFLIB=3D"-L/usr/X11R6/lib -lXm -lXp" LIBDIR=3D"/usr/lib" CFLAGS=3D"-O
> -pipe -march=3Dpentiumpro" CXXFLAGS=3D" -O -pipe -march=3Dpentiumpro"
>       ^^^^^^^^^^^^^^^^^                      ^^^^^^^^^^^^^^^^^
> MANPREFIX=3D"/usr/local" BSD_INSTALL_PROGRAM=3D"install -c -s -o root
> -g wheel -m 555"  BSD_INSTALL_SCRIPT=3D"install -c -o root -g wheel
> -m 555"  BSD_INSTALL_DATA=3D"install -c -o root -g wheel -m 444"
> BSD_INSTALL_MAN=3D"install -c -o root -g wheel -m 444" ./domake
> MAKE=3Dgmake)
>=20
> Running it like this is okay:
>=20
> allmouth# make __MAKE_CONF=3D/dev/null -n do-build | fmt
> (cd /CURRENT/usr/ports/devel/avr-libc/work/avr-libc-2003.05.11;
> /usr/bin/env NO_CPU_CFLAGS=3Dtrue SHELL=3D/bin/sh PORTOBJFORMAT=3Delf
> PREFIX=3D/usr/local LOCALBASE=3D/usr/local X11BASE=3D/usr/X11R6
> MOTIFLIB=3D"-L/usr/X11R6/lib -lXm -lXp" LIBDIR=3D"/usr/lib" CFLAGS=3D"-O
> -pipe " CXXFLAGS=3D" -O -pipe " MANPREFIX=3D"/usr/local"
> BSD_INSTALL_PROGRAM=3D"install -c -s -o root -g wheel -m 555"
> BSD_INSTALL_SCRIPT=3D"install -c -o root -g wheel -m 555"
> BSD_INSTALL_DATA=3D"install -c -o root -g wheel -m 444"
> BSD_INSTALL_MAN=3D"install -c -o root -g wheel -m 444" ./domake
> MAKE=3Dgmake)
>=20
>=20
>=20
> Cheers,
> --=20
> Ruslan Ermilov		Sysadmin and DBA,
> ru@sunbay.com		Sunbay Software AG,
> ru@FreeBSD.org		FreeBSD committer,
> +380.652.512.251	Simferopol, Ukraine
>=20
> http://www.FreeBSD.org	The Power To Serve
> http://www.oracle.com	Enabling The Information Age



--=20
Ruslan Ermilov		Sysadmin and DBA,
ru@sunbay.com		Sunbay Software AG,
ru@FreeBSD.org		FreeBSD committer,
+380.652.512.251	Simferopol, Ukraine

http://www.FreeBSD.org	The Power To Serve
http://www.oracle.com	Enabling The Information Age

--ijf6z65S790CMqo8
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)

iD8DBQE+yMXDUkv4P6juNwoRAlyhAJ0dP7v2B3J5ou704gWOcAZ0Fv9g7gCfcTs2
pryBuMYVgD9jLmBRzG+u46I=
=pgNO
-----END PGP SIGNATURE-----

--ijf6z65S790CMqo8--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030519115339.GI17366>