Date: Tue, 09 Jun 2009 15:34:59 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: kmacy@FreeBSD.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, bz@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r191255 - in head/sys: amd64/conf conf i386/conf net Message-ID: <20090609.153459.1820400761.imp@bsdimp.com> In-Reply-To: <3c1674c90906091012u26b0e823q57a7ea1f42eef22d@mail.gmail.com> References: <200904190016.n3J0G4rA090911@svn.freebsd.org> <20090609143729.R22887@maildrop.int.zabbadoz.net> <3c1674c90906091012u26b0e823q57a7ea1f42eef22d@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <3c1674c90906091012u26b0e823q57a7ea1f42eef22d@mail.gmail.co=
m>
Kip Macy <kmacy@FreeBSD.org> writes:
: > I think FLOWTABLE does nto belong into DEFAULTS. =A0Really DEFAULTS=
was
: > meant for "You cannot boot without this" and if people start to wea=
ken
: > it, DEFAULTS will soon be the new GENERIC. =A0That said I am not su=
re it
: > belongs to GENERIC either.
: =
: I can either push it in to GENERIC or I can change it to NOFLOWTABLE.=
: If you want to remove it from GENERIC then we're going to have to hav=
e
: a lengthy discussion about what most FreeBSD users actually use and
: gut GENERIC as it stands now. The fact is, most FreeBSD users have
: sufficiently few peers that flowtable is a win over using the routing=
: table on every lookup.
NO.
NOFLOWTABLE is bogus. Negative options are lame. We need to have
fewer of them rather than more.
Also, we do *NOT* want it to be default on *ALL* platforms, which is
what NOFLOWTABLE does.
It should be in GENERIC, on a per-platform basis, if it is really
ready for prime time. Embedded targets don't want this kind of stuff
at all. People do mix/match generic, and having all the options there
is the right way to do this. It is what people expect and having some
odd-ball options like this makes it harder. In fact, it makes it
harder to transition between releases because some options are
'magically on' and others need to be updated. It is a big pain. The
project has decided in the past to have the options be normal,
opt-in.
Please, make this a normal option, and we can have the discussion
about which config files it belongs in.
Warner
P.S. I see that you've made it a negative option later in the day
from this message. I'm formally requesting that you back that out and
make it a normal option.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090609.153459.1820400761.imp>