Date: Tue, 24 Jun 2014 13:39:55 +0200 From: Antoine Brodin <antoine@FreeBSD.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, Dmitry Marakasov <amdmi3@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r358059 - head/audio/x11amp Message-ID: <CAALwa8kjaaDVbMXqjs1y=JOL_2jKCj%2B8tF_oR23KLjLFgc6M7w@mail.gmail.com> In-Reply-To: <20140624113632.GA21948@FreeBSD.org> References: <201406162246.s5GMklsu074568@svn.freebsd.org> <20140624111232.GA11118@FreeBSD.org> <CAALwa8=hE-ocFZCUU45uXUxHk-=Mh1cUz7ueS993r50pj2zG1Q@mail.gmail.com> <20140624113632.GA21948@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jun 24, 2014 at 1:36 PM, Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Tue, Jun 24, 2014 at 01:21:57PM +0200, Antoine Brodin wrote: >> On Tue, Jun 24, 2014 at 1:12 PM, Alexey Dokuchaev <danfe@freebsd.org> wrote: >> > On Mon, Jun 16, 2014 at 10:46:47PM +0000, Dmitry Marakasov wrote: >> >> New Revision: 358059 >> >> URL: http://svnweb.freebsd.org/changeset/ports/358059 >> >> QAT: https://qat.redports.org/buildarchive/r358059/ >> >> >> >> Log: >> >> - Switch to USES=libtool, drop .la files >> >> - Mark BROKEN, does not run (BROKENness is not related to libtool change) >> >> [...] >> >> +BROKEN= hangs at start with gtk and linker errors >> > >> > Looks like it you should've used IGNORE instead (run-time problem). >> >> No BROKEN is fine in this case. > > What does "hangs at start" mean? x11amp is invoked during the build for > some sanity testing? > > If the build goes fine (without error), it should be IGNORE, not BROKEN. I disagree, if a port build but doesn't run, it must not be hidden behind IGNORE and must be marked BROKEN. And I will deprecate it in 6 months! Bye bye! Antoine
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8kjaaDVbMXqjs1y=JOL_2jKCj%2B8tF_oR23KLjLFgc6M7w>