Date: Fri, 27 Mar 2009 08:32:51 +0200 From: Vasil Dimov <vd@FreeBSD.org> To: Coleman Kane <cokane@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, Sam Leffler <sam@FreeBSD.org>, src-committers@FreeBSD.org Subject: Re: svn commit: r189828 - in head: include sys/sys Message-ID: <20090327063251.GA95057@polejan.hw.v5d.org> In-Reply-To: <1237567495.1993.2.camel@localhost> References: <200903142010.n2EKAESF006945@svn.freebsd.org> <20090320140015.GA17645@hub.freebsd.org> <20090320153405.GA62675@zim.MIT.EDU> <49C3BCD4.4030605@freebsd.org> <1237567495.1993.2.camel@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
--fUYQa+Pmc3FrFX/N Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 20, 2009 at 12:44:55 -0400, Coleman Kane wrote: [...] > > > On Fri, Mar 20, 2009, Vasil Dimov wrote: > > > =20 > > >> On Sat, Mar 14, 2009 at 08:10:14PM +0000, David Schultz wrote: > > >> =20 > > >>> Author: das > > >>> Date: Sat Mar 14 20:10:14 2009 > > >>> New Revision: 189828 > > >>> URL: http://svn.freebsd.org/changeset/base/189828 > > >>> > > >>> Log: > > >>> Fix the visibility of several prototypes. Also move pthread_kill(= ) and > > >>> pthread_sigmask() to signal.h. In principle, this shouldn't break= anything, > > >>> =20 > > >> [...] > > >> > > >> But it did break, see http://www.freebsd.org/cgi/query-pr.cgi?pr=3D1= 32828 [...] > I was able to solve the problem by removing the "#include <signal.h>" > from the offending file (there is only one) in devel/pth. After that, it > built fine and I am using it now. [...] Hi, I do not have access to 8-current machine so I have some dump questions: 1. From which file did you remove "#include <signal.h>"? I am afraid that if we remove it from pth_p.h.in then this problem could arise again after the user has installed pth and is trying to use it and has included signal.h for some other reason in his source. I.e. if pth's pthread.h and the system's signal.h are included in one source file this problem will resurface. 2. Hmm, why are the prototypes conflicting in the first place? extern int pthread_kill(pthread_t, int); int pthread_kill(__pthread_t, int); 3. /usr/include/signal.h defines pthread_kill() only if __POSIX_VISIBLE or __XSI_VISIBLE is defined. Can someone try to inject #undef __POSIX_VISIBLE or #undef __XSI_VISIBLE into pth's pthread.h.in to see if this fixes the problem and does not cause other problems? Thank you! --=20 Vasil Dimov --fUYQa+Pmc3FrFX/N Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- iEYEARECAAYFAknMcxMACgkQFw6SP/bBpCB5rgCgxW3jDMDFt+4XJPosvM1fHXSW 814An1oLJkV8yrbJdy/DufnyCuBLqyxe =furC -----END PGP SIGNATURE----- --fUYQa+Pmc3FrFX/N--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090327063251.GA95057>