Date: Sun, 20 Nov 2011 22:21:41 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: Attilio Rao <attilio@freebsd.org> Cc: mdf@freebsd.org, "K. Macy" <kmacy@freebsd.org>, Alan Cox <alc@rice.edu>, Andriy Gapon <avg@freebsd.org>, freebsd-current@freebsd.org, Benjamin Kaduk <kaduk@mit.edu>, Penta Upa <bsdboot@gmail.com> Subject: Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3] Message-ID: <20111120202141.GC50300@deviant.kiev.zoral.com.ua> In-Reply-To: <CAJ-FndB%2BJuZDxvHhbGCiikCNoa=XnoS6s_WdPiY3xKjx5LGi%2BA@mail.gmail.com> References: <CAJ-FndDsrVk7EjjtE=QuhaJE1_k7Q1BvQ%2BxriJPnGzLXJQr1sg@mail.gmail.com> <20111116084542.GY50300@deviant.kiev.zoral.com.ua> <CAJ-FndAwWzFJgpCdaaE=YkipZSCtE6Vb8-LEK2_qS=bVhRM3OQ@mail.gmail.com> <20111118105224.GB50300@deviant.kiev.zoral.com.ua> <CAJ-FndAULb9r-FVaBparSJVtoSEQuX7%2BwhCoBNdQi7n%2B=UpEdA@mail.gmail.com> <CAJ-FndCZqwvbi2N=f=5TxkHH3gaKAGxipPoHBCFLqF=sLOTqdQ@mail.gmail.com> <CAJ-FndD%2Bj6WKmsLW9Kv2nDKEJePe=js3xmmj6m6NW3eS1RZD-w@mail.gmail.com> <CAJ-FndD-REes_uHY6EZ3xHEtj2Qn3qX0HCb83xELRmVj9=UaJA@mail.gmail.com> <20111120191835.GB50300@deviant.kiev.zoral.com.ua> <CAJ-FndB%2BJuZDxvHhbGCiikCNoa=XnoS6s_WdPiY3xKjx5LGi%2BA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--kBIJpUqFhZddC6hl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 20, 2011 at 08:22:38PM +0100, Attilio Rao wrote: > 2011/11/20 Kostik Belousov <kostikbel@gmail.com>: > > On Sun, Nov 20, 2011 at 08:04:21PM +0100, Attilio Rao wrote: > >> This other patch converts sx to a similar interface which cleans up vm= _map.c: > >> http://www.freebsd.org/~attilio/sxfileline.patch > >> > >> What do you think about it? > > > > This one only changes the KBI ? Note that _sx suffix is not reserved. >=20 > In which sense? > If you want to keep the shim support for KLD (thus the hard path) you > will always need to keep an hard function and thus you still need a > macro acting as a gate between the 'hard function' (or KLD version, if > you prefer) and the fast case, that is where the "_" suffix came from. As I see, right now kernel exports e.g. _sx_try_slock() for the hard path. After the patch, it will export sx_try_slock_() for the same purpose. The old modules, which call _sx_try_slock(), cannot be loaded into the patched kernel. Am I reading the patch wrong ? --kBIJpUqFhZddC6hl Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iEYEARECAAYFAk7JYVQACgkQC3+MBN1Mb4gINwCdHdKjfFl1RitvK2MeYr16E5Ra No8An2iqH9NOH8ABgfMEhUlsO6LRteQc =ChO2 -----END PGP SIGNATURE----- --kBIJpUqFhZddC6hl--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111120202141.GC50300>