Date: Thu, 31 Mar 2005 12:49:52 +0900 (JST) From: NIIMI Satoshi <sa2c@sa2c.net> To: FreeBSD-gnats-submit@FreeBSD.org Cc: ahze@FreeBSD.org Subject: ports/79386: patch multimedia/gstreamer-plugins: wrong variable substitution for slave plugin ports Message-ID: <20050331034952.4F92A5C2D@berkeley.l.sa2c.net> Resent-Message-ID: <200503310350.j2V3oB3D085198@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 79386
>Category: ports
>Synopsis: patch multimedia/gstreamer-plugins: wrong variable substitution for slave plugin ports
>Confidential: no
>Severity: serious
>Priority: high
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Thu Mar 31 03:50:11 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: NIIMI Satoshi
>Release: FreeBSD 5.3-RELEASE-p6 i386
>Organization:
>Environment:
System: FreeBSD berkeley.l.sa2c.net 5.3-RELEASE-p6 FreeBSD 5.3-RELEASE-p6 #1: Tue Mar 29 14:01:17 JST 2005 root@berkeley.l.sa2c.net:/usr/obj/usr/src/sys/GENERIC i386
>Description:
The variabel CONFIGURE_ARGS is not correctly substituted for
individual plugins, because of undefined variable ${p}.
>How-To-Repeat:
cd /usr/ports/devel/gstreamer-plugins-gconf/; make -V CONFIGURE_ARGS
=> flags for unnecessary plugins are '--enable'
cd /usr/ports/devel/gstreamer-plugins-gconf/; env p=XXX make -V CONFIGURE_ARGS
=> required flags for the plugin are still '--disable'
>Fix:
--- gstreamer-plugins.diff begins here ---
Index: Makefile.common
===================================================================
RCS file: /home/ncvs/ports/multimedia/gstreamer-plugins/Makefile.common,v
retrieving revision 1.7
diff -u -d -r1.7 Makefile.common
--- Makefile.common 25 Mar 2005 21:47:38 -0000 1.7
+++ Makefile.common 31 Mar 2005 03:31:02 -0000
@@ -111,7 +111,7 @@
# Enable the right plugin
-CONFIGURE_ARGS:=${CONFIGURE_ARGS:S|--disable-${p}|--enable-${p}|}
+CONFIGURE_ARGS:=${CONFIGURE_ARGS:S|--disable-${GST_PLUGIN}|--enable-${GST_PLUGIN}|}
# Build/Install directory. defaults to ext/${GST_PLUGIN}
# few plugins are in sys/
--- gstreamer-plugins.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050331034952.4F92A5C2D>