Date: Thu, 4 Oct 2007 11:18:48 +0200 (CEST) From: VANHULLEBUS Yvan <vanhu@netasq.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: kern/116896: Typo in a kassert in GEOM Message-ID: <20071004091848.D222FF74F8@darkstar.netasq.com> Resent-Message-ID: <200710040920.l949K3cB031646@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 116896 >Category: kern >Synopsis: Typo in a kassert in GEOM >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Oct 04 09:20:02 GMT 2007 >Closed-Date: >Last-Modified: >Originator: VANHULLEBUS Yvan >Release: FreeBSD 6.2-STABLE i386 >Organization: NETASQ >Environment: System: FreeBSD darkstar.netasq.com 6.2-STABLE FreeBSD 6.2-STABLE #0: Mon Jan 22 14:18:45 CET 2007 root@darkstar.netasq.com:/usr/obj/usr/src/sys/GENERIC i386 >Description: I'm not sure if this could be a real problem, but there is a small typo in a KASSERT: in geom/geom_subr.c, function g_destroy_provider(), pp->acw is checked twice but pp->ace is not checked. >How-To-Repeat: >Fix: Index: geom/geom_subr.c =================================================================== RCS file: /home/ncvs/src/sys/geom/geom_subr.c,v retrieving revision 1.91 diff -b -u -p -r1.91 geom_subr.c --- geom/geom_subr.c 5 May 2007 16:33:44 -0000 1.91 +++ geom/geom_subr.c 4 Oct 2007 09:14:13 -0000 @@ -554,7 +554,7 @@ g_destroy_provider(struct g_provider *pp ("g_destroy_provider but attached")); KASSERT (pp->acr == 0, ("g_destroy_provider with acr")); KASSERT (pp->acw == 0, ("g_destroy_provider with acw")); - KASSERT (pp->acw == 0, ("g_destroy_provider with ace")); + KASSERT (pp->ace == 0, ("g_destroy_provider with ace")); g_cancel_event(pp); LIST_REMOVE(pp, provider); gp = pp->geom; >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071004091848.D222FF74F8>