Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 20 Sep 2016 18:53:43 +0000 (UTC)
From:      Andriy Voskoboinyk <avos@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r306049 - in head: share/man/man9 sys/dev/ath sys/dev/usb/wlan
Message-ID:  <201609201853.u8KIrhxl046577@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: avos
Date: Tue Sep 20 18:53:42 2016
New Revision: 306049
URL: https://svnweb.freebsd.org/changeset/base/306049

Log:
  net80211: remove IEEE80211_RADIOTAP_TSFT field from transmit definitions.
  
  This field may be used for received frames only.
  
  Differential Revision:	https://reviews.freebsd.org/D3826
  Differential Revision:	https://reviews.freebsd.org/D3827

Modified:
  head/share/man/man9/ieee80211_radiotap.9
  head/sys/dev/ath/if_ath_tx.c
  head/sys/dev/ath/if_athioctl.h
  head/sys/dev/usb/wlan/if_rum.c
  head/sys/dev/usb/wlan/if_rumvar.h
  head/sys/dev/usb/wlan/if_run.c
  head/sys/dev/usb/wlan/if_runvar.h

Modified: head/share/man/man9/ieee80211_radiotap.9
==============================================================================
--- head/share/man/man9/ieee80211_radiotap.9	Tue Sep 20 18:47:33 2016	(r306048)
+++ head/share/man/man9/ieee80211_radiotap.9	Tue Sep 20 18:53:42 2016	(r306049)
@@ -263,7 +263,6 @@ struct wi_rx_radiotap_header {
 and transmit definitions for the Atheros driver:
 .Bd -literal -offset indent
 #define ATH_TX_RADIOTAP_PRESENT (               \\
-        (1 << IEEE80211_RADIOTAP_TSFT)          | \\
         (1 << IEEE80211_RADIOTAP_FLAGS)         | \\
         (1 << IEEE80211_RADIOTAP_RATE)          | \\
         (1 << IEEE80211_RADIOTAP_DBM_TX_POWER)  | \\
@@ -273,7 +272,6 @@ and transmit definitions for the Atheros
 
 struct ath_tx_radiotap_header {
         struct ieee80211_radiotap_header wt_ihdr;
-        uint64_t       wt_tsf;
         uint8_t        wt_flags;
         uint8_t        wt_rate;
         uint8_t        wt_txpower;

Modified: head/sys/dev/ath/if_ath_tx.c
==============================================================================
--- head/sys/dev/ath/if_ath_tx.c	Tue Sep 20 18:47:33 2016	(r306048)
+++ head/sys/dev/ath/if_ath_tx.c	Tue Sep 20 18:53:42 2016	(r306049)
@@ -1538,7 +1538,6 @@ ath_tx_normal_setup(struct ath_softc *sc
     struct ath_buf *bf, struct mbuf *m0, struct ath_txq *txq)
 {
 	struct ieee80211vap *vap = ni->ni_vap;
-	struct ath_hal *ah = sc->sc_ah;
 	struct ieee80211com *ic = &sc->sc_ic;
 	const struct chanAccParams *cap = &ic->ic_wme.wme_chanParams;
 	int error, iswep, ismcast, isfrag, ismrr;
@@ -1822,9 +1821,6 @@ ath_tx_normal_setup(struct ath_softc *sc
 		    sc->sc_hwmap[rix].ieeerate, -1);
 
 	if (ieee80211_radiotap_active_vap(vap)) {
-		u_int64_t tsf = ath_hal_gettsf64(ah);
-
-		sc->sc_tx_th.wt_tsf = htole64(tsf);
 		sc->sc_tx_th.wt_flags = sc->sc_hwmap[rix].txflags;
 		if (iswep)
 			sc->sc_tx_th.wt_flags |= IEEE80211_RADIOTAP_F_WEP;
@@ -2105,7 +2101,6 @@ ath_tx_raw_start(struct ath_softc *sc, s
 	const struct ieee80211_bpf_params *params)
 {
 	struct ieee80211com *ic = &sc->sc_ic;
-	struct ath_hal *ah = sc->sc_ah;
 	struct ieee80211vap *vap = ni->ni_vap;
 	int error, ismcast, ismrr;
 	int keyix, hdrlen, pktlen, try0, txantenna;
@@ -2252,9 +2247,6 @@ ath_tx_raw_start(struct ath_softc *sc, s
 		    sc->sc_hwmap[rix].ieeerate, -1);
 
 	if (ieee80211_radiotap_active_vap(vap)) {
-		u_int64_t tsf = ath_hal_gettsf64(ah);
-
-		sc->sc_tx_th.wt_tsf = htole64(tsf);
 		sc->sc_tx_th.wt_flags = sc->sc_hwmap[rix].txflags;
 		if (wh->i_fc[1] & IEEE80211_FC1_PROTECTED)
 			sc->sc_tx_th.wt_flags |= IEEE80211_RADIOTAP_F_WEP;

Modified: head/sys/dev/ath/if_athioctl.h
==============================================================================
--- head/sys/dev/ath/if_athioctl.h	Tue Sep 20 18:47:33 2016	(r306048)
+++ head/sys/dev/ath/if_athioctl.h	Tue Sep 20 18:53:42 2016	(r306049)
@@ -374,7 +374,6 @@ struct ath_rx_radiotap_header {
 } __packed;
 
 #define ATH_TX_RADIOTAP_PRESENT (		\
-	(1 << IEEE80211_RADIOTAP_TSFT)		| \
 	(1 << IEEE80211_RADIOTAP_FLAGS)		| \
 	(1 << IEEE80211_RADIOTAP_RATE)		| \
 	(1 << IEEE80211_RADIOTAP_DBM_TX_POWER)	| \
@@ -384,7 +383,6 @@ struct ath_rx_radiotap_header {
 
 struct ath_tx_radiotap_header {
 	struct ieee80211_radiotap_header wt_ihdr;
-	u_int64_t	wt_tsf;
 	u_int8_t	wt_flags;
 	u_int8_t	wt_rate;
 	u_int8_t	wt_txpower;

Modified: head/sys/dev/usb/wlan/if_rum.c
==============================================================================
--- head/sys/dev/usb/wlan/if_rum.c	Tue Sep 20 18:47:33 2016	(r306048)
+++ head/sys/dev/usb/wlan/if_rum.c	Tue Sep 20 18:53:42 2016	(r306049)
@@ -1118,7 +1118,6 @@ tr_setup:
 
 				tap->wt_flags = 0;
 				tap->wt_rate = data->rate;
-				rum_get_tsf(sc, &tap->wt_tsf);
 				tap->wt_antenna = sc->tx_ant;
 
 				ieee80211_radiotap_tx(vap, m);

Modified: head/sys/dev/usb/wlan/if_rumvar.h
==============================================================================
--- head/sys/dev/usb/wlan/if_rumvar.h	Tue Sep 20 18:47:33 2016	(r306048)
+++ head/sys/dev/usb/wlan/if_rumvar.h	Tue Sep 20 18:53:42 2016	(r306049)
@@ -44,7 +44,6 @@ struct rum_rx_radiotap_header {
 
 struct rum_tx_radiotap_header {
 	struct ieee80211_radiotap_header wt_ihdr;
-	uint64_t	wt_tsf;
 	uint8_t		wt_flags;
 	uint8_t		wt_rate;
 	uint16_t	wt_chan_freq;
@@ -53,8 +52,7 @@ struct rum_tx_radiotap_header {
 } __packed __aligned(8);
 
 #define RT2573_TX_RADIOTAP_PRESENT					\
-	((1 << IEEE80211_RADIOTAP_TSFT) |				\
-	 (1 << IEEE80211_RADIOTAP_FLAGS) |				\
+	((1 << IEEE80211_RADIOTAP_FLAGS) |				\
 	 (1 << IEEE80211_RADIOTAP_RATE) |				\
 	 (1 << IEEE80211_RADIOTAP_CHANNEL) |				\
 	 (1 << IEEE80211_RADIOTAP_ANTENNA))

Modified: head/sys/dev/usb/wlan/if_run.c
==============================================================================
--- head/sys/dev/usb/wlan/if_run.c	Tue Sep 20 18:47:33 2016	(r306048)
+++ head/sys/dev/usb/wlan/if_run.c	Tue Sep 20 18:53:42 2016	(r306049)
@@ -3077,7 +3077,6 @@ tr_setup:
 			    (struct rt2860_txwi *)(&data->desc + sizeof(struct rt2870_txd));
 			tap->wt_flags = 0;
 			tap->wt_rate = rt2860_rates[data->ridx].rate;
-			run_get_tsf(sc, &tap->wt_tsf);
 			tap->wt_chan_freq = htole16(ic->ic_curchan->ic_freq);
 			tap->wt_chan_flags = htole16(ic->ic_curchan->ic_flags);
 			tap->wt_hwqueue = index;

Modified: head/sys/dev/usb/wlan/if_runvar.h
==============================================================================
--- head/sys/dev/usb/wlan/if_runvar.h	Tue Sep 20 18:47:33 2016	(r306048)
+++ head/sys/dev/usb/wlan/if_runvar.h	Tue Sep 20 18:53:42 2016	(r306049)
@@ -66,7 +66,6 @@ struct run_rx_radiotap_header {
 
 struct run_tx_radiotap_header {
 	struct ieee80211_radiotap_header wt_ihdr;
-	uint64_t	wt_tsf;
 	uint8_t		wt_flags;
 	uint8_t		wt_rate;
 	uint16_t	wt_chan_freq;
@@ -77,8 +76,7 @@ struct run_tx_radiotap_header {
 #define IEEE80211_RADIOTAP_HWQUEUE 15
 
 #define	RUN_TX_RADIOTAP_PRESENT				\
-	(1 << IEEE80211_RADIOTAP_TSFT |			\
-	 1 << IEEE80211_RADIOTAP_FLAGS |		\
+	(1 << IEEE80211_RADIOTAP_FLAGS |		\
 	 1 << IEEE80211_RADIOTAP_RATE |			\
 	 1 << IEEE80211_RADIOTAP_CHANNEL |		\
 	 1 << IEEE80211_RADIOTAP_HWQUEUE)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201609201853.u8KIrhxl046577>