Date: Wed, 1 Oct 2014 14:16:52 -0600 From: Will Andrews <will@firepipe.net> To: NGie Cooper <yaneurabeya@gmail.com> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r272282 - head/share/mk Message-ID: <CADBaqmgG07ZLkb4d8_wLtf2%2B1xd164j0=AsWooPd-Y0LfnDb1w@mail.gmail.com> In-Reply-To: <CAGHfRMB81gj1k3UPLR0yd7StGBmJPUG1eXRLsVYxbxEqnoSECg@mail.gmail.com> References: <201409291505.s8TF5Nhh066884@svn.freebsd.org> <CAGHfRMB81gj1k3UPLR0yd7StGBmJPUG1eXRLsVYxbxEqnoSECg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 1, 2014 at 2:03 PM, NGie Cooper <yaneurabeya@gmail.com> wrote: > This change seems like it introduces a lot of unnecessary complexity > in lieu of someone setting PORTSDIR to the root of their ports tree in > the environment. Sure, but people that are trying to use it somewhere other than /usr/ports shouldn't be surprised by misbehavior. I've worked with several people (who aren't steeped in the usage of ports) who were astonished by this behavior. > Why isn't it using a for-loop by the way? My original implementation used a shell for loop (see the CR), but given the lack of a legitimate use case for looking farther up than three parent directories, it seemed easier not to. I suppose one could use a static list of paths in the for loop though. --Will.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADBaqmgG07ZLkb4d8_wLtf2%2B1xd164j0=AsWooPd-Y0LfnDb1w>