Date: Tue, 4 Feb 2014 15:36:42 +0100 (CET) From: Guido Falsi <madpilot@FreeBSD.org> To: FreeBSD-gnats-submit@freebsd.org Cc: nox@FreeBSD.org Subject: ports/186452: [PATCH] multimedia/vlc: can't build if net/freerdp is installed Message-ID: <3fJT4V3mwxz2r@micro.madpilot.net> Resent-Message-ID: <201402041440.s14Ee0f0042371@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 186452
>Category: ports
>Synopsis: [PATCH] multimedia/vlc: can't build if net/freerdp is installed
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Tue Feb 04 14:40:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator: Guido Falsi
>Release: FreeBSD 10.0-RELEASE amd64
>Organization:
none
>Environment:
System: FreeBSD micro.madpilot.net 10.0-RELEASE FreeBSD 10.0-RELEASE #0 r260789: Thu Jan 16 22:34:59 UTC 2014 root@snap.freebsd.org:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
vlc configure script autodetects FreeRDP and tries to compile against
it. Unluckily this does not work at present, maybe the FreeRDP API
has changed.
Since th porrt at present does not explicitly disable nor enable
FreeRDP support this leaves the port broken on machines which happen
to have FreeRDP installed.
I "fixed" the issue by addinf a FREERDP option, so when this is
disabled (default case) the configure script gets a --disable-freerdp
option and the port compiles anyway. The option has an explicit
"(broken)" warning, and if enabled will mark the port BROKEN.
This also solves the problem with an hidden dependency.
>How-To-Repeat:
# cd /usr/ports/net/freerdp && make install
# cd /usr/ports/multimedia/vlc && make install
>Fix:
Index: Makefile
===================================================================
--- Makefile (revision 342516)
+++ Makefile (working copy)
@@ -22,7 +22,7 @@
RUN_DEPENDS= ffmpeg>=2.0:${PORTSDIR}/multimedia/ffmpeg
OPTIONS_DEFINE= A52 AALIB ASS AVAHI CACA DBUS DIRAC DOCS DTS DVDREAD \
- DVDNAV FAAD FLAC FLUID FRIBIDI GNOMEVFS GNUTLS GOOM \
+ DVDNAV FAAD FLAC FLUID FREERDP FRIBIDI GNOMEVFS GNUTLS GOOM \
HTTPD JACK LIBSSH2 LIRC LIVEMEDIA LUA MAD MATROSKA MODPLUG \
MPEG2 MTP MUSEPACK NCURSES NLS NOTIFY OPTIMIZED_CFLAGS OGG \
OPUS PNG PULSEAUDIO QT4 REALAUDIO RUNROOT \
@@ -39,6 +39,7 @@
DVDREAD_DESC= DVD Playback support
DVDNAV_DESC= DVD menu navigation
FLUID_DESC= Fluidsynth MIDI support
+FREERDP_DESC= RDP support (broken)
GME_DESC= Game_Music_Emu (libgme) support
GNOMEVFS_DESC= Gnome VFS support
GOOM_DESC= the Goom visual effect library
@@ -103,6 +104,9 @@
FLUID_LIB_DEPENDS= libfluidsynth.so:${PORTSDIR}/audio/fluidsynth
FLUID_CONFIGURE_ENABLE= fluidsynth
+FREERDP_LIB_DEPENDS= libfreerdp-core.so:${PORTSDIR}/net/freerdp
+FREERDP_CONFIGURE_ENABLE= freerdp
+
FRIBIDI_LIB_DEPENDS= libfribidi.so:${PORTSDIR}/converters/fribidi
FRIBIDI_CONFIGURE_ENABLE= fribidi
@@ -297,6 +301,10 @@
# End Macro section
#
+.if ${PORT_OPTIONS:MFREERDP}
+BROKEN= FreeRDP suppport fails to compile due to API changes.
+.endif
+
.if ${PORT_OPTIONS:MQT4}
USE_QT4= gui corelib moc_build rcc_build uic_build
.endif
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3fJT4V3mwxz2r>