Date: Thu, 27 Sep 2001 15:53:15 -0700 (PDT) From: John Baldwin <jhb@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/isa intr_machdep.c Message-ID: <XFMail.010927155315.jhb@FreeBSD.org> In-Reply-To: <20010928080117.V49178-100000@delplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 27-Sep-01 Bruce Evans wrote: >> jhb 2001/09/27 12:03:52 PDT >> >> Modified files: >> sys/i386/isa intr_machdep.c >> Log: >> Disable the check in icu_setup() to see if a handler was already used as >> the current interrupt thread routines will guarantee the condition this is >> checking for at a higher level but inthand_add() and inthand_remove() as >> they currently exist don't satisfy this condition. (Which does need to be >> fixed but which will take a bit more work.) This fixes shared interrupts. > > This also "fixes" reassignment of the clock interrupt after failure of the > APIC_IO i8254 test. Urgh. Does this mean that this case leaves 2 useless > threads for clk0 instead of only 1? My system passes the test, but it Yeah, the SMP clock bogon is why I didn't just not call this in the !created_ithd case. I do intend on properly fixing this (we need to call icu_unset() in inthand_remove() if the handler we are removing is a fast interrupt handler, which is the problem.) We won't have 2 useless threads b/c the second time through we use the existing thread in the table. The useless threads will go away when the bigger fix (an interrupt source abstraction separate from ithread) comes along. > Bruce -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010927155315.jhb>