Date: Tue, 02 Jan 2007 11:07:36 -0800 From: Doug Barton <dougb@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: Greg 'groggy' Lehey <grog@freebsd.org>, cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/games/fortune/datfiles fortunes fortunes-o.real Message-ID: <459AAD78.4060307@FreeBSD.org> In-Reply-To: <200701021335.17252.jhb@freebsd.org> References: <200612302154.kBULsfOi057238@repoman.freebsd.org> <20070102003516.GW78631@wantadilla.lemis.com> <459A9CAE.6030909@FreeBSD.org> <200701021335.17252.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote:
> On Tuesday 02 January 2007 12:55, Doug Barton wrote:
>> Greg 'groggy' Lehey wrote:
>>> On Saturday, 30 December 2006 at 21:54:41 +0000, Doug Barton wrote:
>>>> dougb 2006-12-30 21:54:41 UTC
>>>>
>>>> FreeBSD src repository
>>>>
>>>> Modified files:
>>>> games/fortune/datfiles fortunes fortunes-o.real
>>>> Log:
>>>> Add the fortunes from the PR that were not already present.
>>>> Delete some duplicates found while double checking the new ones,
>>>> and fix a typo.
>>>>
>>>> These haven't been sorted yet, but will be in a future commit.
>>> Why didn't you sort them first?
>> Because the rest of the files are not sorted either, and I wanted to
>> keep the commits separate.
>>
>> I have a patch that I'm going to work on getting into the tree today
>> that adds a comment to each file about sorting, and then I'll sort the
>> files obviously. (All of which was discussed and consensus reached a
>> little while ago, I think on -current.) I was going to do it
>> yesterday, but family obligations kept me away from the keyboard.
>
> src/games/fortune/tools/do_sort
Yes, the patch I have adds a note about that.
> They should already be largely sorted (at least 'fortunes') as they've
> been explicitly sorted via do_sort in the past.
They are for the most part, yes. But when I added the new fortunes and
then sorted the file, it was enough different that I felt it would be
better to do it in two stages.
Doug
--
This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?459AAD78.4060307>