Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 15 Jan 2008 23:30:28 GMT
From:      Sam Leffler <sam@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 133369 for review
Message-ID:  <200801152330.m0FNUSSR098531@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=133369

Change 133369 by sam@sam_ebb on 2008/01/15 23:30:17

	must hold mtx over callout_stop when callout setup with init_mtx

Affected files ...

.. //depot/projects/vap/sys/dev/ral/rt2560.c#6 edit
.. //depot/projects/vap/sys/dev/ral/rt2661.c#6 edit

Differences ...

==== //depot/projects/vap/sys/dev/ral/rt2560.c#6 (text) ====

@@ -348,6 +348,7 @@
 	struct ifnet *ifp = ic->ic_ifp;
 	
 	rt2560_stop(sc);
+	RAL_LOCK(sc);
 	callout_stop(&sc->watchdog_ch);
 	callout_stop(&sc->rssadapt_ch);
 

==== //depot/projects/vap/sys/dev/ral/rt2661.c#6 (text) ====

@@ -365,7 +365,8 @@
 	struct ieee80211com *ic = &sc->sc_ic;
 	struct ifnet *ifp = ic->ic_ifp;
 	
-	rt2661_stop(sc);
+	RAL_LOCK(sc);
+	rt2661_stop_locked(sc);
 	callout_stop(&sc->watchdog_ch);
 	callout_stop(&sc->rssadapt_ch);
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200801152330.m0FNUSSR098531>