Date: Wed, 29 May 2002 15:55:36 -0700 (PDT) From: Julian Elischer <julian@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 12110 for review Message-ID: <200205292255.g4TMtaW14655@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://people.freebsd.org/~peter/p4db/chv.cgi?CH=12110 Change 12110 by julian@julian_ref on 2002/05/29 15:54:58 various cleanups suggested by jhb Affected files ... ... //depot/projects/kse/sys/kern/kern_sig.c#53 edit ... //depot/projects/kse/sys/kern/kern_switch.c#47 edit Differences ... ==== //depot/projects/kse/sys/kern/kern_sig.c#53 (text+ko) ==== @@ -84,7 +84,7 @@ static int sig_ffs(sigset_t *set); static int sigprop(int sig); static void stop(struct proc *); - +static void tdsignal(struct thread *td, int sig, sig_t action); static int filt_sigattach(struct knote *kn); static void filt_sigdetach(struct knote *kn); static int filt_signal(struct knote *kn, long hint); @@ -168,6 +168,7 @@ * Determine signal that should be delivered to process p, the current * process, 0 if none. If there is a pending stop signal with default * action, the process stops in issignal(). + * XXXKSE the check for a pending stop is not done under KSE * * MP SAFE. */ @@ -1228,9 +1229,6 @@ mtx_unlock(&Giant); } -static void -tdsignal(struct thread *td, int sig, sig_t action); - /* * Send the signal to the process. If the signal has an action, the action * is usually performed by the target process rather than the caller; we add @@ -1701,7 +1699,6 @@ PROC_LOCK(p->p_pptr); if ((p->p_pptr->p_procsig->ps_flag & PS_NOCLDSTOP) == 0) { - PROC_LOCK(p->p_pptr); psignal(p->p_pptr, SIGCHLD); } PROC_UNLOCK(p->p_pptr); ==== //depot/projects/kse/sys/kern/kern_switch.c#47 (text+ko) ==== @@ -44,7 +44,7 @@ static struct runq runq; SYSINIT(runq, SI_SUB_RUN_QUEUE, SI_ORDER_FIRST, runq_init, &runq) -static void readjustrunqueue(struct runq *rq, struct kse *ke); +static void runq_readjust(struct runq *rq, struct kse *ke); /************************************************************************ * Functions that manipulate runnability from a thread perspective. * ************************************************************************/ @@ -200,7 +200,7 @@ td3->td_kse = ke; ke->ke_thread = td3; kg->kg_last_assigned = td3; - readjustrunqueue(&runq, ke); + runq_readjust(&runq, ke); } else { /* * There is no unassigned thread. @@ -334,7 +334,7 @@ td2->td_kse = NULL; td->td_kse = ke; ke->ke_thread = td; - readjustrunqueue(&runq, ke); + runq_readjust(&runq, ke); } } @@ -561,7 +561,7 @@ } static void -readjustrunqueue(struct runq *rq, struct kse *ke) +runq_readjust(struct runq *rq, struct kse *ke) { if (ke->ke_rqindex != (ke->ke_thread->td_priority / RQ_PPQ)) { To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200205292255.g4TMtaW14655>