Date: Wed, 13 Dec 2000 09:37:50 -0700 From: "Justin T. Gibbs" <gibbs@scsiguy.com> To: Mike Smith <msmith@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf files options src/sys/dev/pci pci_user.c eisa_pci.c pci.c pci_pci.c pcireg.h pcivar.h src/sys/pci pci_compat.c Message-ID: <200012131637.eBDGbos28388@aslan.scsiguy.com> In-Reply-To: Your message of "Tue, 12 Dec 2000 17:25:12 PST." <200012130125.eBD1PCs48656@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
>msmith 2000/12/12 17:25:12 PST > > Modified files: > sys/conf files options > sys/dev/pci eisa_pci.c pci.c pci_pci.c pcireg.h > pcivar.h > Added files: > sys/dev/pci pci_user.c > Removed files: > sys/pci pci_compat.c > Log: > Next round of PCI subsystem updates: ... > - Add prototypes and re-layout the core PCI modules in line with > current coding standards (not a major whitespace change, just moving > the module data to the top of the file). Don't you mean, "reformat to my personal code style"? I meant to talk to you about this before this checkin in regards to the other new files in sys/dev/pci, but since you've brought it up, I'll do so now. It is extremely frustrating to see a mix of styles in this code. Most notable exceptions to style(9) include overflowing 80 columns and using 4 space indentation. As of this checkin, sys/dev/pci.c now has a mix of tab and 4 space indentation where before it was internally consistant with tab intentation. sys/dev/pcivar.h was unilaterally converted to 4 space indentation. Working in this area myself to promote better code sharing with cardbus, reformating the code caused massive conflicts with my changes during the latest cvs merge, and since the reformating was to move away from style(9), they were completely unnecessary. This also sets a bad precedent for our codebase and a bad example for new developers. In fact, I was recently asked to review some code that followed your style by a new developer. When I asked him why he deviated from style(0), he indicated his believe that this was FreeBSD style after having used your code as an example. This is not about your style being better than another, but that we have a mandated style for a reason. You've shown in the past the ability to follow our coding standard, so why are you bucking it now? -- Justin To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200012131637.eBDGbos28388>