Date: Wed, 2 Jul 2014 16:46:09 +0200 From: Tijl Coosemans <tijl@FreeBSD.org> To: Gerald Pfeifer <gerald@pfeifer.com> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, bapt@FreeBSD.org, ports-committers@freebsd.org Subject: Re: svn commit: r351936 - in head: . Mk Mk/Uses archivers/libcomprex archivers/libdynamite archivers/liborange archivers/librtfcomp archivers/lzo2 archivers/ucl archivers/unshield audio/gstreamer1-plug... Message-ID: <20140702164609.000d0561@kalimero.tijl.coosemans.org> In-Reply-To: <alpine.LSU.2.11.1406301209040.30120@tuna.site> References: <201404231325.s3NDPHrv045503@svn.freebsd.org> <alpine.LSU.2.11.1406301209040.30120@tuna.site>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 2 Jul 2014 15:57:02 +0200 (CEST) Gerald Pfeifer wrote:
> Hi Tijl,
>
> On Wed, 23 Apr 2014, Tijl Coosemans wrote:
> > So with this commit USES=libtool is modified to remove .la libraries and a
> > new form (USES=libtool:keepla) is introduced in case they need to be kept
> > (dependency_libs is still emptied).
>
> for lang/gcc* I've been doing
> ${RM} -f ${STAGEDIR}${TARGLIB}/*.la
> for ages. These ports do not have USES=libtool yet, though.
>
> Based on your explanation, I was considering the patch below. Alas
> with that I see lots of the following, so apparently it's not a good
> idea.
>
> ===> Building package for gcc410-4.10.0.s20140629
> pkg-static: lstat(.../stage/scratch2/tmp/gerald/prefix/lib/gcc410/gcc/i386-portbld-freebsd10.0/4.10.0/libcaf_single.la): No such file or directory
> pkg-static: lstat(.../stage/scratch2/tmp/gerald/prefix/lib/gcc410/gcc/i386-portbld-freebsd10.0/4.10.0/libgfortranbegin.la): No such file or directory
> pkg-static: lstat(.../stage/scratch2/tmp/gerald/prefix/lib/gcc410/libsupc++.la): No such file or directory
> pkg-static: lstat(.../stage/scratch2/tmp/gerald/prefix/lib/gcc410/libstdc++.la): No such file or directory
>
>
> What do you recommend? Am I missing something? I can certainly leave
> the ports is as; mainly wanted to be a good citizen. :-)
>
> Gerald
>
> Index: Makefile
> ===================================================================
> --- Makefile (revision 359810)
> +++ Makefile (working copy)
> @@ -32,7 +32,7 @@
> GCC_VERSION= ${PORTVERSION:C/(.+)\.s[0-9]{8}/\1/}
> SUFFIX= ${PORTVERSION:C/([0-9]+).([0-9]+).*/\1\2/}
> ONLY_FOR_ARCHS= amd64 i386 powerpc powerpc64 sparc64
> -USES= gmake iconv perl5 tar:bzip2 makeinfo
> +USES= gmake iconv libtool makeinfo perl5 tar:bzip2
> USE_BINUTILS= yes
> USE_PERL5= build
> SSP_UNSAFE= yes
> @@ -134,7 +134,6 @@
> .endif
>
> post-install:
> - ${RM} -f ${STAGEDIR}${TARGLIB}/*.la
> ${RM} -f ${STAGEDIR}${PREFIX}/man/man7/*
> ${RM} -f ${STAGEDIR}${PREFIX}/bin/rebuild-gcj-db${SUFFIX} \
> ${STAGEDIR}${PREFIX}/man/man1/rebuild-gcj-db${SUFFIX}.1
The problem is that you create plist in post-install while USES=libtool
only removes .la files after staging. I'm thinking of moving the
patch-lafiles target right before post-stage so you can create plist in
post-stage, but for now you'll have to keep the RM (together with
USES=libtool).
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140702164609.000d0561>