Date: Wed, 8 Mar 2006 19:44:27 GMT From: Tim Kuik <tkuik@cisco.com> To: freebsd-gnats-submit@FreeBSD.org Subject: kern/94238: 32 bit overflow prevents proper setting of base in tc_cpu_ticks() Message-ID: <200603081944.k28JiQGr006673@www.freebsd.org> Resent-Message-ID: <200603081950.k28Jo9ul056737@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 94238 >Category: kern >Synopsis: 32 bit overflow prevents proper setting of base in tc_cpu_ticks() >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Mar 08 19:50:09 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Tim Kuik >Release: current >Organization: Cisco >Environment: FreeBSD tkuik-freebsd.cisco 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Mon Mar 6 12:49:57 CST 2006 root@tkuik-freebsd.cisco:/usr/obj/usr/src/sys/GENERIC i386 >Description: in kern_tc.c: tc_cpu_ticks(), the line base += tc->tc_counter_mask + 1; will cause a 32 bit overflow if the tc_counter_mask is 0xffffffff, resulting in base not being incremented. >How-To-Repeat: As long as the mask is set to 0xffffffff, it will always happen. >Fix: Change the line to: base += (uint64_t)(tc->tc_counter_mask) + 1; >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200603081944.k28JiQGr006673>