Date: Fri, 31 May 2002 20:07:16 +0200 From: Bernd Walter <ticso@cicely5.cicely.de> To: Julian Elischer <julian@elischer.org> Cc: ticso@cicely.de, Julian Elischer <julian@FreeBSD.ORG>, Perforce Change Reviews <perforce@FreeBSD.ORG> Subject: Re: PERFORCE change 12204 for review Message-ID: <20020531180715.GB16281@cicely5.cicely.de> In-Reply-To: <Pine.BSF.4.21.0205311052520.28852-100000@InterJet.elischer.org> References: <20020531174748.GA16281@cicely5.cicely.de> <Pine.BSF.4.21.0205311052520.28852-100000@InterJet.elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 31, 2002 at 10:54:14AM -0700, Julian Elischer wrote: > no that cast is to unsigned int as that is what suword() takes > as an argument.. It takes an unsigned long and will spite a compile time warning on alpha because of casting the 64 bit pointer td->td_mailbox into a 32 bit value. > I would rather have a sptr() and fptr() set that is guaranteed to be > correct. > > comments from others? > > > On Fri, 31 May 2002, Bernd Walter wrote: > > > On Fri, May 31, 2002 at 10:23:22AM -0700, Julian Elischer wrote: > > > http://people.freebsd.org/~peter/p4db/chv.cgi?CH=12204 > > > > > > Change 12204 by julian@julian_ref on 2002/05/31 10:22:47 > > > > > > Change type of a pointer variable > > > > > > Affected files ... > > > > > > ... //depot/projects/kse/sys/kern/kern_thread.c#52 edit > > > > > > Differences ... > > > > > > ==== //depot/projects/kse/sys/kern/kern_thread.c#52 (text+ko) ==== > > > > > > @@ -251,7 +251,7 @@ > > > thread_export_context(struct thread *td) > > > { > > > struct kse *ke; > > > - uint td2_mbx; /* XXXKSE */ > > > + uintptr_t td2_mbx; > > > void *addr1; > > > void *addr2; > > > int error; > > > > Don't forget the (uint) cast later in the same function. -- B.Walter COSMO-Project http://www.cosmo-project.de ticso@cicely.de Usergroup info@cosmo-project.de To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020531180715.GB16281>