Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 04 Mar 2009 13:56:06 -0700 (MST)
From:      "M. Warner Losh" <imp@bsdimp.com>
To:        rnoland@FreeBSD.org
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org
Subject:   Re: svn commit: r189367 - head/sys/dev/pci
Message-ID:  <20090304.135606.1649768480.imp@bsdimp.com>
In-Reply-To: <200903041823.n24INmcc049524@svn.freebsd.org>
References:  <200903041823.n24INmcc049524@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
In message: <200903041823.n24INmcc049524@svn.freebsd.org>
            Robert Noland <rnoland@freebsd.org> writes:
: Author: rnoland
: Date: Wed Mar  4 18:23:48 2009
: New Revision: 189367
: URL: http://svn.freebsd.org/changeset/base/189367
: 
: Log:
:   Extend the management of PCIM_CMD_INTxDIS.
:   
:   We now explicitly enable INTx during bus_setup_intr() if it is needed.
:   Several of the ata drivers were managing this bit internally.  This is
:   better handled in pci and it should work for all drivers now.
:   
:   We also mask INTx during bus_teardown_intr() by setting this bit.
:   
:   Reviewed by:	jhb
:   MFC after:	3 days

Note: the INTxDIS bit is new in PCI 3.0, and has no effect on earlier
devices.  This should be highlighted in the comments somewhere...

Warner



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090304.135606.1649768480.imp>