Skip site navigation (1)Skip section navigation (2) 
Date:      Thu, 25 Feb 2016 01:24:02 +0000 (UTC)
From:      Jared McNeill <jmcneill@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r296019 - head/sys/arm/allwinner
Message-ID:  <201602250124.u1P1O27Y033697@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: jmcneill
Date: Thu Feb 25 01:24:02 2016
New Revision: 296019
URL: https://svnweb.freebsd.org/changeset/base/296019

Log:
  Fix dedicated DMA transfers.
  
  For sources and destinations marked "noincr", the previous code was
  incorrectly programming the dedicated DMA channel control register
  using bit definitions for normal DMA channels. This code path is not
  currently used, but will be used by the HDMI audio driver in review.
  
  Reviewed by:		andrew
  Approved by:		gonzo (mentor)
  Differential Revision:	https://reviews.freebsd.org/D5382

Modified:
  head/sys/arm/allwinner/a10_dmac.c

Modified: head/sys/arm/allwinner/a10_dmac.c
==============================================================================
--- head/sys/arm/allwinner/a10_dmac.c	Thu Feb 25 01:10:56 2016	(r296018)
+++ head/sys/arm/allwinner/a10_dmac.c	Thu Feb 25 01:24:02 2016	(r296019)
@@ -222,8 +222,8 @@ a10dmac_set_config(device_t dev, void *p
 {
 	struct a10dmac_channel *ch = priv;
 	uint32_t val;
-	unsigned int dst_dw, dst_bl, dst_bs, dst_wc;
-	unsigned int src_dw, src_bl, src_bs, src_wc;
+	unsigned int dst_dw, dst_bl, dst_bs, dst_wc, dst_am;
+	unsigned int src_dw, src_bl, src_bs, src_wc, src_am;
 
 	switch (cfg->dst_width) {
 	case 8:
@@ -284,16 +284,23 @@ a10dmac_set_config(device_t dev, void *p
 	      (src_dw << AWIN_DMA_CTL_SRC_DATA_WIDTH_SHIFT) |
 	      (src_bl << AWIN_DMA_CTL_SRC_BURST_LEN_SHIFT) |
 	      (cfg->src_drqtype << AWIN_DMA_CTL_SRC_DRQ_TYPE_SHIFT);
-	if (cfg->dst_noincr) {
-		val |= AWIN_NDMA_CTL_DST_ADDR_NOINCR;
-	}
-	if (cfg->src_noincr) {
-		val |= AWIN_NDMA_CTL_SRC_ADDR_NOINCR;
-	}
 
 	if (ch->ch_type == CH_NDMA) {
+		if (cfg->dst_noincr)
+			val |= AWIN_NDMA_CTL_DST_ADDR_NOINCR;
+		if (cfg->src_noincr)
+			val |= AWIN_NDMA_CTL_SRC_ADDR_NOINCR;
+
 		DMACH_WRITE(ch, AWIN_NDMA_CTL_REG, val);
 	} else {
+		dst_am = cfg->dst_noincr ? AWIN_DDMA_CTL_DMA_ADDR_IO :
+		    AWIN_DDMA_CTL_DMA_ADDR_LINEAR;
+		src_am = cfg->src_noincr ? AWIN_DDMA_CTL_DMA_ADDR_IO :
+		    AWIN_DDMA_CTL_DMA_ADDR_LINEAR;
+
+		val |= (dst_am << AWIN_DDMA_CTL_DST_ADDR_MODE_SHIFT);
+		val |= (src_am << AWIN_DDMA_CTL_SRC_ADDR_MODE_SHIFT);
+
 		DMACH_WRITE(ch, AWIN_DDMA_CTL_REG, val);
 
 		dst_bs = cfg->dst_blksize - 1;

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201602250124.u1P1O27Y033697>