Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 7 Mar 2014 05:17:44 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        "Lev A. Serebryakov" <lev@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r345100 - in head/devel/libopencm3: . files
Message-ID:  <20140307051744.GA9177@FreeBSD.org>
In-Reply-To: <201402191508.s1JF8uOK086607@svn.freebsd.org>
References:  <201402191508.s1JF8uOK086607@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Feb 19, 2014 at 03:08:56PM +0000, Lev A. Serebryakov wrote:
> New Revision: 345100
> URL: http://svnweb.freebsd.org/changeset/ports/345100
> QAT: https://qat.redports.org/buildarchive/r345100/
> 
>  @@ -1,4 +1,4 @@
>  -#!/usr/bin/env python
> -+#!/usr/bin/env python2
> ++#! /usr/bin/env /usr/local/bin/python2

Can you elaborate on this change a bit?  env(1) is mostly used in this
situation to rely on PATH value in the environment, to avoid having to
specify full path to the executable, but you do precisely this.  Is it
a typo, or you rely to some other variable passed via environment?  It
also contains a style bug (space after #!).  Original line looked good
already (/usr/local/bin is in our PATH), unless I'm missing something.

> -+#!/usr/bin/python2
> ++#! /usr/local/bin/python2

This one makes more sense (modulo the style bug), but then again: what
is wrong with canonical '#!/usr/bin/env python2' ?

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140307051744.GA9177>