Date: Wed, 15 Jul 2009 08:41:56 -0400 From: John Baldwin <jhb@freebsd.org> To: freebsd-current@freebsd.org Cc: Roman Divacky <rdivacky@freebsd.org>, current@freebsd.org Subject: Re: ppc(4) locking of isa_dma* Message-ID: <200907150841.56605.jhb@freebsd.org> In-Reply-To: <20090715104934.GA58659@freebsd.org> References: <20090715104934.GA58659@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 15 July 2009 6:49:35 am Roman Divacky wrote: > hi > > the isa_dma* functions seem to require Giant. ppc(4) uses those > but does not seem to lock Giant or anything. is this ok? > is it a bug? Doh, that is a bug. > I looked at the i386/isa/isa_dma.c and it seems pretty selfcontained > (ie. it operates on hw and it's own variables). would it be sufficient > to just introduce a new lock and lock with it all the isa_dma* functions > ? or is there some indirect dependency on Giant that I cant see? That would probably work. If it can be self-contained in the isa_dma API that would so that consumers do not need fixing that would be ideal. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200907150841.56605.jhb>