Date: Tue, 30 Apr 2013 14:27:01 +0100 From: Andrew Turner <andrew@fubar.geek.nz> To: Grzegorz Bernacki <gjb@semihalf.com> Cc: freebsd-arm@freebsd.org, Olivier Houchard <cognet@FreeBSD.org> Subject: Re: RFC: Patches with AXP support and pmap&smp fixes. Message-ID: <20130430142701.5bbfec2b@bender.lan> In-Reply-To: <517E8610.5050204@semihalf.com> References: <517E8610.5050204@semihalf.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 29 Apr 2013 16:39:12 +0200 Grzegorz Bernacki <gjb@semihalf.com> wrote: > Hi, >=20 > I am going to submit some changes related to Armada XP support and > some general ARM fixes. You can find them at: > http://people.freebsd.org/~gber/armada >=20 > It would be good if someone could review changes in generic ARM code > i.e.: 1) > http://people.freebsd.org/~gber/armada/0004-arm-smp-Fix-AP-processors-ini= tialization-procedure.patch >=20 > This patch fixes race condition in pcpu_init function. pcpu_init=20 > performs operation on signly-linked tail queue and the queue can be=20 > corrupted by secondary cpus initialization. =46rom this patch I can infer you have used FreeBSD ARM with SMP. Have you tried with WITNESS enabled? If not can you try? There is a known issue where accessing curthread is non-atomic when it is required to be. In it's current state mutexes may fail when they are unlocked. Olivier Houchard had a patch a few months ago to rework how the data is stored. My understanding is this helped but I have not seen or tried the patch. Olivier, is the above correct, and are we able to get this work into the tree so we can work on making SMP stable? Andrew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130430142701.5bbfec2b>