Date: Fri, 07 Mar 2014 11:01:44 +0100 From: John Marino <freebsd.contact@marino.st> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, d@delphij.net, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Mathieu Arnold <mat@FreeBSD.org>, Xin LI <delphij@FreeBSD.org> Subject: Re: svn commit: r345165 - head/devel/hgsvn Message-ID: <53199908.4010008@marino.st> In-Reply-To: <20140307095715.GB16063@FreeBSD.org> References: <201402192351.s1JNplot033193@svn.freebsd.org> <20140307070536.GB48720@FreeBSD.org> <CE672AB00747E2D97403FA66@atuin.in.mat.cc> <53198F86.3020800@delphij.net> <20140307094336.GB3390@FreeBSD.org> <531995DB.5000806@marino.st> <20140307095715.GB16063@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3/7/2014 10:57, Alexey Dokuchaev wrote: > On Fri, Mar 07, 2014 at 10:48:11AM +0100, John Marino wrote: >> On 3/7/2014 10:43, Alexey Dokuchaev wrote: >>> DIST_SUBDIR is most useful in few cases [...] >> >> 4) When upstream "rerolls" their distribution files. >> The first time this happens, DIST_SUBDIR should get created with a >> unique date. Otherwise you could have fetch mismatches when the port >> distinfo is fixed but the old distfile is still on the system. > > Yes, I had thought about this case, but deliberately did not mention it as I > believe that using DIST_SUBDIR as a remedy for upstream stupidity is abusing > it. Instead, upstream should be educated, politely, yet persistently, about > how to roll distfiles correctly. That said, while "distfile rerolling" case > can indeed be solved with DIST_SUBDIR, IMHO it should not be recommended way. They are not mutually exclusive. You can and should educate upstream. In the meantime, the damage is done and needs to be dealt with properly. It's to the maintainer's benefit to educate upstream to avoid PRs and constantly updating the port, so this is no crutch. It doesn't stop additional work, it's just correct. John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53199908.4010008>