Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 31 Aug 2004 14:40:56 -0600
From:      Scott Long <scottl@freebsd.org>
To:        Brooks Davis <brooks@one-eyed-alien.net>
Cc:        freebsd-arch@freebsd.org
Subject:   Re: option directive and turning on AOE
Message-ID:  <4134E258.4060903@freebsd.org>
In-Reply-To: <20040831203929.GB25134@odin.ac.hmc.edu>
References:  <Pine.LNX.4.60.0408311611550.7530@athena> <4134DF35.7070605@freebsd.org> <20040831203929.GB25134@odin.ac.hmc.edu>

next in thread | previous in thread | raw e-mail | index | archive | help
Brooks Davis wrote:

> On Tue, Aug 31, 2004 at 02:27:33PM -0600, Scott Long wrote:
> 
>>Sam wrote:
>>
>>
>>>I've added code to if_ethersubr.c:/ether_demux/
>>>to queue up AoE frames as they appear.  I followed
>>>suit with other protocols and included my addition
>>>inside of an #ifdef AOE.  Where do I turn this on?
>>>I thought perhaps just adding an 'option AOE' to
>>>the config would do it, but it doesn't -- so clearly
>>>I don't understand how the option directive works.
>>>The config man page doesn't talk about option/device
>>>directives ...
>>>
>>>I'm still looking, but a clue would be well received.
>>
>>Did you modify /sys/conf/options to tell it about your
>>AOE option?  If so, then you should have specified the name
>>of a header file that the option would be #define'd into.
>>Include that header file in if_ethersubr.c and you should
>>have no problems.
>>
>>Incidentally, this might be an area when netgraph would be
>>useful.  Instead of having an AoE specific hook in the
>>stack, you could have an AoE netgraph module that uses the
>>existing netgraph hooks.  It's just an idea, though.
> 
> 
> Another option might be a PFIL hook.  There isn't one there now, but I
> think I've seen talk of adding one.  Actually, if we did that, we could
> get most of the netgraph specific hooks out of the ethernet code.
> 
> -- Brooks
> 

Do the PFIL hooks exist in 4.x?  I know that he's trying to target
his driver for that right now.  Netgraph exists in both, so using it
would keep his code more portable.  Anyways, this isn't my area of
expertise, so do whatever you find to be best.

Scott



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4134E258.4060903>