Date: Mon, 11 Nov 2013 23:38:18 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Eitan Adler <eadler@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, Bryan Drewery <bryan@shatow.net> Subject: Re: svn commit: r257945 - head/usr.sbin/pkg Message-ID: <20131111193818.GA7577@FreeBSD.org> In-Reply-To: <CAF6rxgm73FnyFgGcD2YA0MZ3Q=sHpqmS3QAbsP8BV2Qyx2z7mw@mail.gmail.com> References: <201311110744.rAB7iA6g041490@svn.freebsd.org> <20131111153544.GI98118@admin.xzibition.com> <CAF6rxgm73FnyFgGcD2YA0MZ3Q=sHpqmS3QAbsP8BV2Qyx2z7mw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Nov 11, 2013 at 02:19:38PM -0500, Eitan Adler wrote: E> On Mon, Nov 11, 2013 at 10:35 AM, Bryan Drewery <bryan@shatow.net> wrote: E> > On Mon, Nov 11, 2013 at 07:44:10AM +0000, Gleb Smirnoff wrote: E> >> Author: glebius E> >> Date: Mon Nov 11 07:44:09 2013 E> >> New Revision: 257945 E> >> URL: http://svnweb.freebsd.org/changeset/base/257945 E> >> E> >> Log: E> >> Do not use just freed memory. E> >> E> >> Sponsored by: Nginx, Inc. E> > E> > Can you please also MFC this? E> > E> >> if (fingerprint->name) E> >> free(fingerprint->name); E> E> While here, can you remove the if conditional by the free? I'll do the MFC, but this styling issue I'd leave to pkg developers. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131111193818.GA7577>