Date: Thu, 6 Jun 2002 08:17:27 -0700 (PDT) From: John Baldwin <jhb@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 12427 for review Message-ID: <200206061517.g56FHRk65330@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://people.freebsd.org/~peter/p4db/chv.cgi?CH=12427 Change 12427 by jhb@jhb_laptop on 2002/06/06 08:17:18 Don't call printf while holding a spin lock. Hopefully this will fix the SMP hang with witness when exiting single user mode. Actually, since the text that was printed was "de" before the hang, I'm fairly sure this will fix the problem in question. Affected files ... ... //depot/projects/smpng/sys/kern/subr_witness.c#51 edit Differences ... ==== //depot/projects/smpng/sys/kern/subr_witness.c#51 (text+ko) ==== @@ -383,9 +383,9 @@ mtx_lock_spin(&w_mtx); MPASS(w->w_refcount > 0); w->w_refcount--; + mtx_unlock_spin(&w_mtx); if (w->w_refcount == 0) printf("dead witness: %s\n", w->w_name); - mtx_unlock_spin(&w_mtx); } mtx_lock(&all_mtx); To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200206061517.g56FHRk65330>