Date: Fri, 10 Feb 2012 21:38:51 -0500 From: Maxim Khitrov <max@mxcrypt.com> To: rflynn@acsalaska.net Cc: Alex Dupre <ale@freebsd.org>, freebsd-ports@freebsd.org Subject: Re: Requested changes to lang/php5 port Message-ID: <CAJcQMWcNJK2q-tRskzppBmpiptH3w4axmGWT7Ws-WeaztuEXBQ@mail.gmail.com> In-Reply-To: <2705.46.129.107.107.1328924592.squirrel@mymail.acsalaska.net> References: <CAJcQMWf3NXt1Bn=qXxsqa5ZTOnZ=R0xPAALNRfT8bTWQkhLaiA@mail.gmail.com> <CAJcQMWegXp6jd8E2nc7=uhHp9EB7hwQFRutmjsG3VTCcRy9=_w@mail.gmail.com> <2705.46.129.107.107.1328924592.squirrel@mymail.acsalaska.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--f46d043c7c862436fd04b8a727ea Content-Type: text/plain; charset=UTF-8 On Fri, Feb 10, 2012 at 8:43 PM, <rflynn@acsalaska.net> wrote: >> On Fri, Feb 10, 2012 at 12:41 PM, Maxim Khitrov <max@mxcrypt.com> wrote: >>> Hello, >>> >>> I'd like to request two minor changes to the lang/php5 port: >>> >>> 1. Change 'CONFIGURE_ARGS=' line to 'CONFIGURE_ARGS+=' to allow >>> customizations to the arguments. One reason for this is that some >>> extensions, like security/php5-hash, have to be compiled into the >>> core. Otherwise, 'session.hash_function' option cannot use hash >>> algorithms offered by that extension. See the following bug report for >>> more info: >>> >>> https://bugs.php.net/bug.php?id=53789 >>> >>> 2. Unless there is a very good reason for keeping them, I think >>> '--enable-libxml' and especially '--enable-mysqlnd' should be removed >>> from the default set of arguments. Make these two part of the options >>> dialog, if you want, but there are plenty of installations that have >>> no need for any MySQL or XML functionality. Why compile these into the >>> core by default? >> >> Actually, I now realize that changing 'CONFIGURE_ARGS=' to >> 'CONFIGURE_ARGS+=' wouldn't help me, because --disable-all would >> negate --enable-hash, which I was planning to specify. > > No, it won't negate it. --disable-all means "start with an empty set and > for each --enable-foo add foo to the set". > > You can add to CONFIGURE_ARGS using a Makefile.local which is included > at bsd.port.pre.mk time. Didn't know about Makefile.local, thanks! I tested the 'CONFIGURE_ARGS+=' solution and it does work. I was under the impression that order mattered. That method is slightly better than Makefile.local, because I try to manage all port customizations with portconf. Otherwise, it's easy to forget all the changes you made to get things working exactly right. I also exclude /usr/ports from backups, so all settings would revert to their defaults if I ever had to re-extract the entire tree. >> As for removing --enable-libxml, it seems to be required when building >> the port (maybe for fpm?), but --enable-mysqlnd should definitely be >> removed by default. > > As far as I can tell, --enable-mysqlnd does not add to dependencies, as: > make -C /usr/ports/lang/php5 all-depends-list > shows me as does: > % ls /var/db/pkg|egrep 'php|mysql' > php5-5.3.9 True, but it's still unnecessary. It increases the size of all binaries (php, php-cgi, php-fpm) and adds a ton of useless information to phpinfo() output. I think that making it an option that is enabled by default is perfectly reasonable. I've attached a patch that does this. Tested it on FreeBSD 9.0-RELEASE amd64. - Max --f46d043c7c862436fd04b8a727ea Content-Type: application/octet-stream; name="php5-mysqlnd.patch" Content-Disposition: attachment; filename="php5-mysqlnd.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gyi10hd00 LS0tIE1ha2VmaWxlLm9yaWcJMjAxMi0wMi0xMCAxMzoxNToyNi4wMDAwMDAwMDAgLTA1MDAKKysr IE1ha2VmaWxlCTIwMTItMDItMTAgMjE6MTk6NTkuMDAwMDAwMDAwIC0wNTAwCkBAIC0yNSwxMyAr MjUsMTIgQEAKCiBMSUJfREVQRU5EUz0JcGNyZS4wOiR7UE9SVFNESVJ9L2RldmVsL3BjcmUKCi1D T05GSUdVUkVfQVJHUz0JXAorQ09ORklHVVJFX0FSR1MrPQlcCiAJCS0td2l0aC1sYXlvdXQ9R05V IFwKIAkJLS1sb2NhbHN0YXRlZGlyPS92YXIgXAogCQktLXdpdGgtY29uZmlnLWZpbGUtc2Nhbi1k aXI9JHtQUkVGSVh9L2V0Yy9waHAgXAogCQktLWRpc2FibGUtYWxsIFwKIAkJLS1lbmFibGUtbGli eG1sIFwKLQkJLS1lbmFibGUtbXlzcWxuZCBcCiAJCS0td2l0aC1saWJ4bWwtZGlyPSR7TE9DQUxC QVNFfSBcCiAJCS0td2l0aC1wY3JlLXJlZ2V4PSR7TE9DQUxCQVNFfSBcCiAJCS0td2l0aC16bGli LWRpcj0vdXNyIFwKQEAgLTQ5LDcgKzQ4LDggQEAKIAkJTVVMVElCWVRFICJFbmFibGUgemVuZCBt dWx0aWJ5dGUgc3VwcG9ydCIgb2ZmIFwKIAkJSVBWNiAiRW5hYmxlIGlwdjYgc3VwcG9ydCIgb24g XAogCQlNQUlMSEVBRCAiRW5hYmxlIG1haWwgaGVhZGVyIHBhdGNoIiBvZmYgXAotCQlMSU5LVEhS ICJMaW5rIHRocmVhZCBsaWIgKGZvciB0aHJlYWRlZCBleHRlbnNpb25zKSIgb2ZmCisJCUxJTktU SFIgIkxpbmsgdGhyZWFkIGxpYiAoZm9yIHRocmVhZGVkIGV4dGVuc2lvbnMpIiBvZmYgXAorCQlN WVNRTE5EICJFbmFibGUgTXlTUUwgbmF0aXZlIGRyaXZlciIgb24KCiBDT05GTElDVFM9CXBocDQt NCogcGhwNS1wY3JlLSogcGhwNS1zcGwtKgoKQEAgLTE1Niw2ICsxNTYsMTMgQEAKIENPTkZJR1VS RV9BUkdTKz0tLWRpc2FibGUtaXB2NgogLmVuZGlmCgorLmlmICFkZWZpbmVkKFdJVEhPVVRfTVlT UUxORCkKK0NPTkZJR1VSRV9BUkdTKz0tLWVuYWJsZS1teXNxbG5kCitQTElTVF9TVUIrPSAgICAg TVlTUUxORD0iIgorLmVsc2UKK1BMSVNUX1NVQis9ICAgICBNWVNRTE5EPSJAY29tbWVudCAiCisu ZW5kaWYKKwogcG9zdC1wYXRjaDoKIAlAJHtUT1VDSH0gJHtXUktTUkN9L2V4dC9waHBfY29uZmln LmgKIAlAJHtSRUlOUExBQ0VfQ01EfSAic3xeXChleHRlbnNpb25fZGlyXCl8OyBcMXwiICR7V1JL U1JDfS9waHAuaW5pLSoKLS0tIHBrZy1wbGlzdC5vcmlnCTIwMTItMDItMTAgMjE6MjA6NTQuMDAw MDAwMDAwIC0wNTAwCisrKyBwa2ctcGxpc3QJMjAxMi0wMi0xMCAyMToyMTozMy4wMDAwMDAwMDAg LTA1MDAKQEAgLTg4LDIzICs4OCwyMyBAQAogaW5jbHVkZS9waHAvZXh0L2VyZWcvcmVnZXgvcmVn ZXgyLmgKIGluY2x1ZGUvcGhwL2V4dC9lcmVnL3JlZ2V4L3V0aWxzLmgKIGluY2x1ZGUvcGhwL2V4 dC9saWJ4bWwvcGhwX2xpYnhtbC5oCi1pbmNsdWRlL3BocC9leHQvbXlzcWxuZC9jb25maWctd2lu LmgKLWluY2x1ZGUvcGhwL2V4dC9teXNxbG5kL215c3FsbmQuaAotaW5jbHVkZS9waHAvZXh0L215 c3FsbmQvbXlzcWxuZF9ibG9ja19hbGxvYy5oCi1pbmNsdWRlL3BocC9leHQvbXlzcWxuZC9teXNx bG5kX2NoYXJzZXQuaAotaW5jbHVkZS9waHAvZXh0L215c3FsbmQvbXlzcWxuZF9kZWJ1Zy5oCi1p bmNsdWRlL3BocC9leHQvbXlzcWxuZC9teXNxbG5kX2VudW1fbl9kZWYuaAotaW5jbHVkZS9waHAv ZXh0L215c3FsbmQvbXlzcWxuZF9saWJteXNxbF9jb21wYXQuaAotaW5jbHVkZS9waHAvZXh0L215 c3FsbmQvbXlzcWxuZF9uZXQuaAotaW5jbHVkZS9waHAvZXh0L215c3FsbmQvbXlzcWxuZF9wb3J0 YWJpbGl0eS5oCi1pbmNsdWRlL3BocC9leHQvbXlzcWxuZC9teXNxbG5kX3ByaXYuaAotaW5jbHVk ZS9waHAvZXh0L215c3FsbmQvbXlzcWxuZF9yZXN1bHQuaAotaW5jbHVkZS9waHAvZXh0L215c3Fs bmQvbXlzcWxuZF9yZXN1bHRfbWV0YS5oCi1pbmNsdWRlL3BocC9leHQvbXlzcWxuZC9teXNxbG5k X3N0YXRpc3RpY3MuaAotaW5jbHVkZS9waHAvZXh0L215c3FsbmQvbXlzcWxuZF9zdHJ1Y3RzLmgK LWluY2x1ZGUvcGhwL2V4dC9teXNxbG5kL215c3FsbmRfd2lyZXByb3RvY29sLmgKLWluY2x1ZGUv cGhwL2V4dC9teXNxbG5kL3BocF9teXNxbG5kLmgKLWluY2x1ZGUvcGhwL2V4dC9teXNxbG5kL3Bo cF9teXNxbG5kX2NvbmZpZy5oCislJU1ZU1FMTkQlJWluY2x1ZGUvcGhwL2V4dC9teXNxbG5kL2Nv bmZpZy13aW4uaAorJSVNWVNRTE5EJSVpbmNsdWRlL3BocC9leHQvbXlzcWxuZC9teXNxbG5kLmgK KyUlTVlTUUxORCUlaW5jbHVkZS9waHAvZXh0L215c3FsbmQvbXlzcWxuZF9ibG9ja19hbGxvYy5o CislJU1ZU1FMTkQlJWluY2x1ZGUvcGhwL2V4dC9teXNxbG5kL215c3FsbmRfY2hhcnNldC5oCisl JU1ZU1FMTkQlJWluY2x1ZGUvcGhwL2V4dC9teXNxbG5kL215c3FsbmRfZGVidWcuaAorJSVNWVNR TE5EJSVpbmNsdWRlL3BocC9leHQvbXlzcWxuZC9teXNxbG5kX2VudW1fbl9kZWYuaAorJSVNWVNR TE5EJSVpbmNsdWRlL3BocC9leHQvbXlzcWxuZC9teXNxbG5kX2xpYm15c3FsX2NvbXBhdC5oCisl JU1ZU1FMTkQlJWluY2x1ZGUvcGhwL2V4dC9teXNxbG5kL215c3FsbmRfbmV0LmgKKyUlTVlTUUxO RCUlaW5jbHVkZS9waHAvZXh0L215c3FsbmQvbXlzcWxuZF9wb3J0YWJpbGl0eS5oCislJU1ZU1FM TkQlJWluY2x1ZGUvcGhwL2V4dC9teXNxbG5kL215c3FsbmRfcHJpdi5oCislJU1ZU1FMTkQlJWlu Y2x1ZGUvcGhwL2V4dC9teXNxbG5kL215c3FsbmRfcmVzdWx0LmgKKyUlTVlTUUxORCUlaW5jbHVk ZS9waHAvZXh0L215c3FsbmQvbXlzcWxuZF9yZXN1bHRfbWV0YS5oCislJU1ZU1FMTkQlJWluY2x1 ZGUvcGhwL2V4dC9teXNxbG5kL215c3FsbmRfc3RhdGlzdGljcy5oCislJU1ZU1FMTkQlJWluY2x1 ZGUvcGhwL2V4dC9teXNxbG5kL215c3FsbmRfc3RydWN0cy5oCislJU1ZU1FMTkQlJWluY2x1ZGUv cGhwL2V4dC9teXNxbG5kL215c3FsbmRfd2lyZXByb3RvY29sLmgKKyUlTVlTUUxORCUlaW5jbHVk ZS9waHAvZXh0L215c3FsbmQvcGhwX215c3FsbmQuaAorJSVNWVNRTE5EJSVpbmNsdWRlL3BocC9l eHQvbXlzcWxuZC9waHBfbXlzcWxuZF9jb25maWcuaAogaW5jbHVkZS9waHAvZXh0L3BjcmUvcGhw X3BjcmUuaAogaW5jbHVkZS9waHAvZXh0L3NwbC9waHBfc3BsLmgKIGluY2x1ZGUvcGhwL2V4dC9z cGwvc3BsX2FycmF5LmgKQEAgLTI0NCw3ICsyNDQsNyBAQAogQGRpcnJtIGluY2x1ZGUvcGhwL2V4 dC9lcmVnL3JlZ2V4CiBAZGlycm0gaW5jbHVkZS9waHAvZXh0L2VyZWcKIEBkaXJybSBpbmNsdWRl L3BocC9leHQvbGlieG1sCi1AZGlycm0gaW5jbHVkZS9waHAvZXh0L215c3FsbmQKKyUlTVlTUUxO RCUlQGRpcnJtIGluY2x1ZGUvcGhwL2V4dC9teXNxbG5kCiBAZGlycm0gaW5jbHVkZS9waHAvZXh0 L3BjcmUKIEBkaXJybSBpbmNsdWRlL3BocC9leHQvc3BsCiBAZGlycm0gaW5jbHVkZS9waHAvZXh0 L3N0YW5kYXJkCg== --f46d043c7c862436fd04b8a727ea--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJcQMWcNJK2q-tRskzppBmpiptH3w4axmGWT7Ws-WeaztuEXBQ>