Date: Mon, 25 Apr 2011 16:10:11 GMT From: Robert Andersson <streambag@streambag.se> To: freebsd-bugs@FreeBSD.org Subject: Re: misc/156637: sys/types.h can't be included when _XOPEN_SOURCE is defined Message-ID: <201104251610.p3PGABQa060683@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR misc/156637; it has been noted by GNATS. From: Robert Andersson <streambag@streambag.se> To: Bruce Evans <brde@optusnet.com.au> Cc: freebsd-gnats-submit@freebsd.org, freebsd-bugs@freebsd.org Subject: Re: misc/156637: sys/types.h can't be included when _XOPEN_SOURCE is defined Date: Mon, 25 Apr 2011 17:44:31 +0200 On Mon, 25 Apr 2011 19:10:00 +1000 (EST) Bruce Evans <brde@optusnet.com.au> wrote: > > I've used the following fix (the first of the above) for 10 years or > so (it got lost in fixes for mounds of style bugs in <sys/file.h>). > I didn't notice it in connection with _XOPEN_SOURCE, but by general > principles. > > % Index: file.h > % =================================================================== > % RCS file: /home/ncvs/src/sys/sys/file.h,v > % retrieving revision 1.65 > % diff -u -2 -r1.65 file.h > % --- file.h 19 Jun 2004 11:38:00 -0000 1.65 > % +++ file.h 20 Jun 2004 02:11:04 -0000 > % @@ -151,5 +142,5 @@ > % void *xf_data; /* file descriptor specific > data */ % void *xf_vnode; /* vnode pointer */ > % - u_int xf_flag; /* flags (see fcntl.h) */ > % + unsigned xf_flag; /* flags (see fcntl.h) */ > % }; > % > > Bruce > Hi, Thanks for responding! Your patch definitely solves the problem. I found this when trying to port an application to FreeBSD. I guess I can work around the problem by patching the code using file.h to define __BSD_VISIBLE, but it would be great if this fix could be committed so that the workaround can be removed eventually. Cheers, Robert
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201104251610.p3PGABQa060683>