Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 01 May 2011 11:29:58 -0700
From:      Doug Barton <dougb@FreeBSD.org>
To:        Boris Samorodov <bsam@FreeBSD.org>
Cc:        cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/multimedia Makefile ports/multimedia/zoneminder Makefile distinfo pkg-descr pkg-plist ports/multimedia/zoneminder/files README.FreeBSD patch-Makefile.in patch-configure patch-db_zm_create.sql.in patch-src_Makefile.am ...
Message-ID:  <4DBDA6A6.3050603@FreeBSD.org>
In-Reply-To: <201104291422.p3TEMbNd097337@repoman.freebsd.org>
References:  <201104291422.p3TEMbNd097337@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Couple of problems with the rc.d script. Overall it looks good, but we 
prefer the name of the file, PROVIDE, and $name to all be the same. 
Especially with a short $name like zm there is a lot of potential for 
conflict. Making them the same also makes debugging a lot easier. More 
importantly, the unconditional 'sleep 10' is not ok. I'm not sure what 
you're trying to accomplish there, but if it's necessary to sleep after 
starting the service for example, you could define start_postcmd='sleep 
10'.

Meanwhile, command_args="$1" is quite clever. :)


Doug


On 04/29/2011 07:22, Boris Samorodov wrote:
> bsam        2011-04-29 14:22:37 UTC
>
>    FreeBSD ports repository
>
>    Modified files:
>      multimedia           Makefile
>    Added files:
>      multimedia/zoneminder Makefile distinfo pkg-descr pkg-plist
>      multimedia/zoneminder/files README.FreeBSD patch-Makefile.in
>                                  patch-configure
>                                  patch-db_zm_create.sql.in
>                                  patch-src_Makefile.am
>                                  patch-src_Makefile.in
>                                  patch-src_zm_comms.cpp
>                                  patch-src_zm_comms.h
>                                  patch-src_zm_event.cpp
>                                  patch-src_zm_event.h
>                                  patch-src_zm_ffmpeg_camera.cpp
>                                  patch-src_zm_image.cpp
>                                  patch-src_zm_jpeg.c
>                                  patch-src_zm_jpeg.h
>                                  patch-src_zm_local_camera.h
>                                  patch-src_zm_monitor.cpp
>                                  patch-src_zm_mpeg.cpp
>                                  patch-src_zm_remote_camera.h
>                                  patch-src_zm_sdp.cpp
>                                  patch-src_zm_signal.h
>                                  patch-src_zmc.cpp
>                                  patch-src_zmu.cpp videodev.h zm.in
>                                  zm_fbsd_camera.cpp
>                                  zm_fbsd_camera.h
>    Log:
>    Zoneminder is an all-in-one GPL'd security and surveillance camera solution.
>    Fully web-based system for viewing and analyzing security camera feeds.
>
>    WWW: http://www.zoneminder.com/
>
>    Revision  Changes    Path
>    1.438     +1 -0      ports/multimedia/Makefile
>    1.1       +121 -0    ports/multimedia/zoneminder/Makefile (new)
>    1.1       +5 -0      ports/multimedia/zoneminder/distinfo (new)
>    1.1       +213 -0    ports/multimedia/zoneminder/files/README.FreeBSD (new)
>    1.1       +20 -0     ports/multimedia/zoneminder/files/patch-Makefile.in (new)
>    1.1       +92 -0     ports/multimedia/zoneminder/files/patch-configure (new)
>    1.1       +166 -0    ports/multimedia/zoneminder/files/patch-db_zm_create.sql.in (new)
>    1.1       +12 -0     ports/multimedia/zoneminder/files/patch-src_Makefile.am (new)
>    1.1       +10 -0     ports/multimedia/zoneminder/files/patch-src_Makefile.in (new)
>    1.1       +11 -0     ports/multimedia/zoneminder/files/patch-src_zm_comms.cpp (new)
>    1.1       +16 -0     ports/multimedia/zoneminder/files/patch-src_zm_comms.h (new)
>    1.1       +44 -0     ports/multimedia/zoneminder/files/patch-src_zm_event.cpp (new)
>    1.1       +20 -0     ports/multimedia/zoneminder/files/patch-src_zm_event.h (new)
>    1.1       +11 -0     ports/multimedia/zoneminder/files/patch-src_zm_ffmpeg_camera.cpp (new)
>    1.1       +20 -0     ports/multimedia/zoneminder/files/patch-src_zm_image.cpp (new)
>    1.1       +26 -0     ports/multimedia/zoneminder/files/patch-src_zm_jpeg.c (new)
>    1.1       +10 -0     ports/multimedia/zoneminder/files/patch-src_zm_jpeg.h (new)
>    1.1       +25 -0     ports/multimedia/zoneminder/files/patch-src_zm_local_camera.h (new)
>    1.1       +10 -0     ports/multimedia/zoneminder/files/patch-src_zm_monitor.cpp (new)
>    1.1       +11 -0     ports/multimedia/zoneminder/files/patch-src_zm_mpeg.cpp (new)
>    1.1       +11 -0     ports/multimedia/zoneminder/files/patch-src_zm_remote_camera.h (new)
>    1.1       +11 -0     ports/multimedia/zoneminder/files/patch-src_zm_sdp.cpp (new)
>    1.1       +16 -0     ports/multimedia/zoneminder/files/patch-src_zm_signal.h (new)
>    1.1       +27 -0     ports/multimedia/zoneminder/files/patch-src_zmc.cpp (new)
>    1.1       +20 -0     ports/multimedia/zoneminder/files/patch-src_zmu.cpp (new)
>    1.1       +404 -0    ports/multimedia/zoneminder/files/videodev.h (new)
>    1.1       +39 -0     ports/multimedia/zoneminder/files/zm.in (new)
>    1.1       +807 -0    ports/multimedia/zoneminder/files/zm_fbsd_camera.cpp (new)
>    1.1       +0 -0      ports/multimedia/zoneminder/files/zm_fbsd_camera.h (new)
>    1.1       +4 -0      ports/multimedia/zoneminder/pkg-descr (new)
>    1.1       +311 -0    ports/multimedia/zoneminder/pkg-plist (new)
>
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/Makefile.diff?&r1=1.437&r2=1.438&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/Makefile
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/distinfo
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/files/README.FreeBSD
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/files/patch-Makefile.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/files/patch-configure
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/files/patch-db_zm_create.sql.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/files/patch-src_Makefile.am
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/files/patch-src_Makefile.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/files/patch-src_zm_comms.cpp
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/files/patch-src_zm_comms.h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/files/patch-src_zm_event.cpp
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/files/patch-src_zm_event.h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/files/patch-src_zm_ffmpeg_camera.cpp
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/files/patch-src_zm_image.cpp
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/files/patch-src_zm_jpeg.c
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/files/patch-src_zm_jpeg.h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/files/patch-src_zm_local_camera.h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/files/patch-src_zm_monitor.cpp
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/files/patch-src_zm_mpeg.cpp
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/files/patch-src_zm_remote_camera.h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/files/patch-src_zm_sdp.cpp
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/files/patch-src_zm_signal.h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/files/patch-src_zmc.cpp
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/files/patch-src_zmu.cpp
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/files/videodev.h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/files/zm.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/files/zm_fbsd_camera.cpp
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/files/zm_fbsd_camera.h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/pkg-descr
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/zoneminder/pkg-plist
>



-- 

	Nothin' ever doesn't change, but nothin' changes much.
			-- OK Go

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4DBDA6A6.3050603>