Date: Tue, 05 May 2009 18:46:05 +0300 From: Andriy Gapon <avg@icyb.net.ua> To: Maxim Sobolev <sobomax@FreeBSD.org> Cc: FreeBSD Hackers <freebsd-hackers@FreeBSD.org> Subject: Re: C99: Suggestions for style(9) Message-ID: <4A005F3D.7010606@icyb.net.ua> In-Reply-To: <49FAE36D.9030109@FreeBSD.org> References: <49F4070C.2000108@gmx.de> <20090428121327.GA41168@freebsd.org> <49FA8F2D.5090708@gmx.de> <49FAE36D.9030109@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
on 01/05/2009 14:56 Maxim Sobolev said the following: > Christoph Mallon wrote: >> Roman Divacky schrieb: >>> I like the part about using as many variables as possible because >>> of documentation and performance enhancements. I tend to like >>> the other changes as well.. >> >> This is not about using as many variables as possible. The goal is to >> use as many variables as you have logically distinct entities in the >> function. I suppose, this is what you mean, but I want to clarify this >> point. > > Why don't just put "logically distinct entities" into separate functions > on their own? It's a good indicator that the re-factoring is due when > you reach this point. I think that you overreach. A very trivial example. An array and an index into the array are two sufficiently "logically distinct entities" [as to be different variables]. But they are sufficiently related to be used in the same function. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A005F3D.7010606>