Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 5 May 2007 20:05:37 GMT
From:      Matt Jacob <mjacob@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 119299 for review
Message-ID:  <200705052005.l45K5bK1081326@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=119299

Change 119299 by mjacob@mjexp on 2007/05/05 20:05:20

	misplaced isp_free_pcmd led to a panic at double free.

Affected files ...

.. //depot/projects/mjexp/sys/dev/isp/isp_freebsd.c#24 edit

Differences ...

==== //depot/projects/mjexp/sys/dev/isp/isp_freebsd.c#24 (text+ko) ====

@@ -2478,7 +2478,6 @@
 			    isp_watchdog, ccb);
 			break;
 		case CMD_RQLATER:
-			isp_free_pcmd(isp, ccb);
 			/*
 			 * Handle initial and subsequent loop down cases
 			 */
@@ -2495,6 +2494,7 @@
 				ccb->ccb_h.status =
 				    CAM_SEL_TIMEOUT|CAM_DEV_QFRZN;
 				xpt_freeze_devq(ccb->ccb_h.path, 1);
+				isp_free_pcmd(isp, ccb);
 				xpt_done(ccb);
 				break;
 			}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200705052005.l45K5bK1081326>