Date: Thu, 13 Nov 2008 10:11:19 -0800 (PST) From: Doug Ambrisko <ambrisko@ambrisko.com> To: Kostik Belousov <kostikbel@gmail.com> Cc: svn-src-head@FreeBSD.org, Doug Ambrisko <ambrisko@FreeBSD.org>, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r184934 - head/sys/ufs/ffs Message-ID: <200811131811.mADIBJOj099325@ambrisko.com> In-Reply-To: <20081113174740.GV47073@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
Kostik Belousov writes: | On Thu, Nov 13, 2008 at 05:40:21PM +0000, Doug Ambrisko wrote: | > Author: ambrisko | > Date: Thu Nov 13 17:40:21 2008 | > New Revision: 184934 | > URL: http://svn.freebsd.org/changeset/base/184934 | > | > Log: | > For now on every 10 cyclinder groups flush the buffer cache to free | > up space. If the buffer cache fills up then the disk systems can | > grind to a halt. Better tuning can be figured out later. | > | > Tested by: Tim, others and work | > Reviewed by: Kostik Belousov | > PR: 128832 | > | > Modified: | > head/sys/ufs/ffs/ffs_snapshot.c | > | > Modified: head/sys/ufs/ffs/ffs_snapshot.c | > ============================================================================== | > --- head/sys/ufs/ffs/ffs_snapshot.c Thu Nov 13 17:13:16 2008 (r184933) | > +++ head/sys/ufs/ffs/ffs_snapshot.c Thu Nov 13 17:40:21 2008 (r184934) | > @@ -351,6 +351,8 @@ restart: | > if (error) | > goto out; | > bawrite(nbp); | > + if (cg % 10 == 0) | > + ffs_syncvnode(vp, MNT_WAIT); | > } | > /* | > * Copy all the cylinder group maps. Although the | > @@ -372,6 +374,8 @@ restart: | > goto out; | > error = cgaccount(cg, vp, nbp, 1); | > bawrite(nbp); | > + if (cg % 10 == 0) | > + ffs_syncvnode(vp, MNT_WAIT); | > if (error) | > goto out; | > } | Thank you ! | | Please, MFC it for 7.1. I'll wait for some of the dust to settle first. Also I want to test a 7.1 machine here without any of my patches, then start adding some back it. I should be able to get that mostly done today unless I get hit with other work stuff. From my perspective I have a couple of low risk patches that should go in but look more radical. Doug A.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200811131811.mADIBJOj099325>