Date: Sat, 27 Apr 2002 16:08:29 -0700 From: Peter Wemm <peter@wemm.org> To: Maxime Henrion <mux@FreeBSD.ORG> Cc: current@FreeBSD.ORG Subject: Re: Recent commit to sys/kern/kern_environment.c broke reading tunables Message-ID: <20020427230829.970ED38FD@overcee.wemm.org> In-Reply-To: <20020427205753.1F69938FD@overcee.wemm.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Peter Wemm wrote: > Maxime Henrion wrote: > > Hi, > > > > > > I think I may have found the bug. Could someone test the attached patch > > and report if it fixes the problem or not ? > > > > Thanks in advance, > > Maxime > > No joy: > > FreeBSD 5.0-CURRENT #8: Sat Apr 27 13:48:13 PDT 2002 > peter@ashburton.netplex.com.au:/home/src/sys/alpha/compile/ASHBURTON > Preloaded elf kernel "/boot/kernel/kernel" at 0xfffffc00005f6000. > EB164 > Digital AlphaPC 164SX 533 MHz, 531MHz > 8192 byte page size, 1 processor. > CPU: PCA56 (21164PC) major=9 minor=2 extensions=0x101<BWX,MVI> > OSF PAL rev: 0x1000600020117 > real memory = 132038656 (128944K bytes) > <hang> > > Sorry.. :-/ (I'll look at this today) This turned out to be part of the problem. I committed your patch and another followup that got the rest of it. The outstanding problems were: 1) checkmethod caused use_kenv to be set only once and the next time it was called, use_kenv would stay at zero and static hints only got used. 2) the termination of the kenvp[] loop could do a null deref. Anyway, I've committed both your and my changes, it should be working now. If anybody else sees problems still, please yell. Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020427230829.970ED38FD>