Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 16 Dec 2014 16:13:20 +0200
From:      Alex Kozlov <ak@FreeBSD.org>
To:        Mathieu Arnold <mat@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r374800 - head/Mk/Uses
Message-ID:  <20141216141320.GA28332@ravenloft.kiev.ua>
In-Reply-To: <5B209A4BD7689CD74744CFA7@ogg.in.absolight.net>
References:  <201412161206.sBGC6fa5045717@svn.freebsd.org> <54902709.9090801@marino.st> <71EBD6FD6D89266B6651554A@ogg.in.absolight.net> <20141216133802.GA27647@ravenloft.kiev.ua> <5B209A4BD7689CD74744CFA7@ogg.in.absolight.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 16, 2014 at 02:47:09PM +0100, Mathieu Arnold wrote:
> +--On 16 décembre 2014 15:38:02 +0200 Alex Kozlov <ak@FreeBSD.org> wrote:
> | On Tue, Dec 16, 2014 at 01:41:26PM +0100, Mathieu Arnold wrote:
> |> +--On 16 décembre 2014 13:35:21 +0100 John Marino
> |> <freebsd.contact@marino.st> wrote:
> |> | On 12/16/2014 13:06, Mathieu Arnold wrote:
> |> |> Author: mat
> |> |> Date: Tue Dec 16 12:06:40 2014
> |> |> New Revision: 374800
> |> |> URL: https://svnweb.freebsd.org/changeset/ports/374800
> |> |> QAT: https://qat.redports.org/buildarchive/r374800/
> |> |> 
> |> |> Log:
> |> |>   ts=8, repeat after me, ts=8.
> |> |>   
> |> |>   With hat:	perl@
> |> |>   Sponsored by:	Absolight
> |> |> 
> |> |> Modified:
> |> |>   head/Mk/Uses/perl5.mk
> |> |> 
> |> | 
> |> | This is not just a perl thing.  search for "ts=4" and other 4-space
> |> | tabs indicators in Mk, it's full of them (e.g. grep -nr "ts=4"
> |> | /usr/ports/Mk).  If ts should be 8 across the board (and I think it
> |> | should be), then all of these need to be changes and then documented.
> |> Yes, it should, feel free to pitch in and provide patches to fix some
> |> other files :-)
> | Allow me to ask, why it should be 8 and not 4?
> Because a tabulation is 8 spaces.  It should be consistent over the whole
> ports tree.
Well, 'Please view me with 4 column tabs!' line was added to bsd.port.mk
more than 20 year ago, in rev 69, because it's inconvenient to view it with
default tabulation value: many wrapped lines, indentation too deep, etc.


-- 
Alex



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141216141320.GA28332>