Date: Tue, 23 Dec 2008 08:10:03 GMT From: "Artem Naluzhnyy" <tut@nhamon.com.ua> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/129814: [patch] support of per script nice(1) value in periodic.conf(5) Message-ID: <200812230810.mBN8A3km068026@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/129814; it has been noted by GNATS.
From: "Artem Naluzhnyy" <tut@nhamon.com.ua>
To: "Garrett Cooper" <yanefbsd@gmail.com>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: bin/129814: [patch] support of per script nice(1) value in periodic.conf(5)
Date: Tue, 23 Dec 2008 09:28:01 +0200
Hi,
On Tue, Dec 23, 2008 at 01:44, Garrett Cooper <yanefbsd@gmail.com> wrote:
> The only issue with this is that:
>
> if [ -n "${_nice}" ]
>
> and:
>
> elif [ -n "${default_nice}" ]
>
> don't check for valid number values. I'm not sure if we'd want to
> throw in that logic or not (or if there's something else in our
> rc-scripts that automatically checks for numbers in range)...
>
> I'd ask (quickly) on hackers@ to see if the change makes sense for a
> more widespread review.
Actually the same feature for rc.conf file has no integer value syntax
check and produces the same error message from nice(1):
nice: qwerty: invalid nice value
--
Artem Naluzhnyy
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200812230810.mBN8A3km068026>