Date: Mon, 11 Nov 2013 21:42:32 +0000 (UTC) From: Bryan Drewery <bdrewery@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r258020 - head/usr.sbin/pkg Message-ID: <201311112142.rABLgWKU030333@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: bdrewery (ports committer) Date: Mon Nov 11 21:42:31 2013 New Revision: 258020 URL: http://svnweb.freebsd.org/changeset/base/258020 Log: Remove useless checks for NULL pointer before free(3) Reported by: eadler Approved by: eadler Modified: head/usr.sbin/pkg/pkg.c Modified: head/usr.sbin/pkg/pkg.c ============================================================================== --- head/usr.sbin/pkg/pkg.c Mon Nov 11 21:27:57 2013 (r258019) +++ head/usr.sbin/pkg/pkg.c Mon Nov 11 21:42:31 2013 (r258020) @@ -326,8 +326,7 @@ free_fingerprint_list(struct fingerprint struct fingerprint *fingerprint, *tmp; STAILQ_FOREACH_SAFE(fingerprint, list, next, tmp) { - if (fingerprint->name) - free(fingerprint->name); + free(fingerprint->name); free(fingerprint); } free(list); @@ -729,12 +728,9 @@ cleanup: if (revoked) free_fingerprint_list(revoked); if (sc) { - if (sc->cert) - free(sc->cert); - if (sc->sig) - free(sc->sig); - if (sc->name) - free(sc->name); + free(sc->cert); + free(sc->sig); + free(sc->name); free(sc); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201311112142.rABLgWKU030333>