Date: Mon, 13 Jan 2014 09:29:22 +0100 From: John Marino <freebsd.contact@marino.st> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Antoine Brodin <antoine@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r338297 - head/deskutils/aspostit Message-ID: <52D3A3E2.2010004@marino.st> In-Reply-To: <20140113082141.GA8735@FreeBSD.org> References: <201312311310.rBVDAOJv097942@svn.freebsd.org> <20140113082141.GA8735@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 1/13/2014 09:21, Alexey Dokuchaev wrote: > On Tue, Dec 31, 2013 at 01:10:24PM +0000, Antoine Brodin wrote: >> New Revision: 338297 >> URL: http://svnweb.freebsd.org/changeset/ports/338297 >> >> do-install: >> - (cd ${WRKSRC} && ${INSTALL_PROGRAM} aspostit ${PREFIX}/bin) >> - (cd ${WRKSRC} && ${INSTALL_MAN} aspostit.1 ${MANPREFIX}/man/man1) >> + ${INSTALL_PROGRAM} ${WRKSRC}/aspostit ${STAGEDIR}${PREFIX}/bin >> + ${INSTALL_MAN} ${WRKSRC}/aspostit.1 ${STAGEDIR}${MANPREFIX}/man/man1 > > Thank you for restoring sanity of the installation commands. Unfortunately > we have quite a lot of these in the tree since recently, and I truly welcome > cleaning of this mess! This is basically, "Why take two commands for what can be done with one?" right? While I can see a preference for a single command, the end result is correct on either method. I'd classify this as "nicer style" rather than "restoring sanity". The original way isn't so offensive to me, especially if several commands follow the "cd" command or if the "cd" is used to control the output of the ${FIND} command.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52D3A3E2.2010004>