Date: Fri, 27 Aug 2004 07:23:01 +0200 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Brian Fundakowski Feldman <green@FreeBSD.org> Cc: Roman Kurakin <rik@cronyx.ru> Subject: Re: cvs commit: src/sys/geom/concat g_concat.c src/sys/geom/label g_label.c src/sys/geom/mirror g_mirror.c src/sys/geom/raid3 g_raid3.c src/sys/geom/stripe g_stripe.c Message-ID: <75045.1093584181@critter.freebsd.dk> In-Reply-To: Your message of "Thu, 26 Aug 2004 16:15:31 EDT." <20040826201531.GQ77326@green.homeunix.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20040826201531.GQ77326@green.homeunix.org>, Brian Fundakowski Feldm an writes: >> >Why in the world would you crash the machine when you don't have to? >> >> To prevent bogus code from being committed in the first place. >> >> Presumably if people can not make their code work because it panics >> they will not commit it. > >You cannot presume testing will expose every possible state/condition. If you hit any of the KASSERTS in geom, your code is very broken and if your testing doesn't uncover that (with the help of the KASSERTS) then you have no business being a committer. >It hasn't in FreeBSD's past, but maybe you can start a revolution that >makes it simple to create very complete test suites and put them into >the tree along with the code being tested. I've been of the most vocal advocates of getting regression tests into the tree for longer than you have been a committer. I was me who added src/tools originally. Now, shut up and code. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?75045.1093584181>