Date: Thu, 24 Nov 2016 11:26:24 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r308687 - head/libexec/rtld-elf Message-ID: <20161124092624.GP54029@kib.kiev.ua> In-Reply-To: <19b061c5-cd2b-f098-e8b1-aca308e61c31@FreeBSD.org> References: <201611150937.uAF9bZPg082363@repo.freebsd.org> <19b061c5-cd2b-f098-e8b1-aca308e61c31@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 23, 2016 at 11:06:53AM -0800, Bryan Drewery wrote: > On 11/15/2016 1:37 AM, Konstantin Belousov wrote: > > Author: kib > > Date: Tue Nov 15 09:37:35 2016 > > New Revision: 308687 > > URL: https://svnweb.freebsd.org/changeset/base/308687 > > > > Log: > > Update hint to utilize user variable. > > > > Sponsored by: The FreeBSD Foundation > > MFC after: 1 week > > > > Modified: > > head/libexec/rtld-elf/Makefile > > > > Modified: head/libexec/rtld-elf/Makefile > > ============================================================================== > > --- head/libexec/rtld-elf/Makefile Tue Nov 15 09:20:28 2016 (r308686) > > +++ head/libexec/rtld-elf/Makefile Tue Nov 15 09:37:35 2016 (r308687) > > @@ -2,7 +2,7 @@ > > > > # Use the following command to build local debug version of dynamic > > # linker: > > -# make DEBUG_FLAGS=-g DEBUG=-DDEBUG MK_TESTS=no all > > +# make DEBUG_FLAGS=-g DEBUG=-DDEBUG WITHOUT_TESTS=yes all > > What prompted this change? Passing MK_TESTS=no should work fine. I thought that the intent was to expose WITH_/WITHOUT_ knobs to users, and keep MK_ to internal build machinery. This most likely come from reading commit logs which I cannot dig now. For start, only WITH_/WITHOUT_ are documented in src.conf. Second, the very beginning of src.opts.mk says # Users define WITH_FOO and WITHOUT_FOO on the command line or in /etc/src.conf # and /etc/make.conf files. These translate in the build system to MK_FOO={yes,no} # with sensible (usually) defaults. Then it adds # Define MK_* variables (which are either "yes" or "no") for users # to set via WITH_*/WITHOUT_* in /etc/src.conf and override in the # make(1) environment. IMO it is relatively easy to make the same conclusion as I did, from the text above. > > > > > .include <src.opts.mk> > > PACKAGE= clibs > > > > > -- > Regards, > Bryan Drewery >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20161124092624.GP54029>