Date: Wed, 26 Nov 2008 21:32:04 -0500 From: Alexander Kabaev <kabaev@gmail.com> To: Jack F Vogel <jfv@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r185356 - head/sys/dev/ixgbe Message-ID: <20081126213204.14db9a63@kan.dnsalias.net> In-Reply-To: <200811270219.mAR2Ji2M073024@svn.freebsd.org> References: <200811270219.mAR2Ji2M073024@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/xwJ66CLH=qBQHy._dxUvhsV Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Thu, 27 Nov 2008 02:19:44 +0000 (UTC) Jack F Vogel <jfv@FreeBSD.org> wrote: > Author: jfv > Date: Thu Nov 27 02:19:44 2008 > New Revision: 185356 > URL: http://svn.freebsd.org/changeset/base/185356 >=20 > Log: > Small nit I just noticed, a pre-decrement should be post. >=20 > Modified: > head/sys/dev/ixgbe/ixgbe.c >=20 > Modified: head/sys/dev/ixgbe/ixgbe.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/dev/ixgbe/ixgbe.c Thu Nov 27 02:18:43 2008 > (r185355) +++ head/sys/dev/ixgbe/ixgbe.c Thu Nov 27 02:19:44 > 2008 (r185356) @@ -3244,7 +3244,7 @@ fail: > * the rings that completed, the failing case will have > * cleaned up for itself. 'j' failed, so its the terminus. > */ > - for (int i =3D 0; i < j; ++i) { > + for (int i =3D 0; i < j; i++) { > rxr =3D &adapter->rx_rings[i]; > for (int n =3D 0; n < adapter->num_rx_desc; n++) { > struct ixgbe_rx_buf *rxbuf; Is C99 construct here intentional? If so, when did we agree on using only C99 compilers on our code base? =20 --=20 Alexander Kabaev --Sig_/xwJ66CLH=qBQHy._dxUvhsV Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iD8DBQFJLgakQ6z1jMm+XZYRAqekAJ9pUNa0z76G7JdZmiaOFZdtPpSougCeJ6cV kYDeSGSBJmyIqBOfv4EWwTo= =GEf0 -----END PGP SIGNATURE----- --Sig_/xwJ66CLH=qBQHy._dxUvhsV--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081126213204.14db9a63>