Date: Tue, 15 Jul 2008 18:26:21 -0400 (EDT) From: Igor Roshchin <str@komkon.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/125655: Incorrect startup variable in mail/up-imapproxy rc.d/imapproxyd.sh Message-ID: <200807152226.m6FMQL6B069544@trantor.komkon.org> Resent-Message-ID: <200807152230.m6FMU2PL036574@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 125655
>Category: ports
>Synopsis: Incorrect startup variable in mail/up-imapproxy rc.d/imapproxyd.sh
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Jul 15 22:30:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Igor Roshchin
>Release: FreeBSD 5.4-RELEASE i386
>Organization:
Komkon
>Environment:
System: FreeBSD myhost.domain.com 5.4-RELEASE FreeBSD 5.4-RELEASE #2: Tue Jul 12 16:03:42 EDT 2005 root@myhost.domain.com:/usr/obj/usr/src/sys/NEW i386
>Description:
/usr/local/etc/rc.d/imapproxyd.sh incorrectly uses imapproxyd_conf
variable that is not being used by /etc/rc.subr:
# imapproxyd_conf (file): Set location of conf file.
# Default is "/usr/local/etc/imapproxyd.conf"
Hence, this config file location is not being read by the program.
As a result, the program looks for the hardcoded default:
/etc/imapproxy.conf
As far as I can tell, /etc/rc.subr does not contain ${name}_conf
even on 6.x and 7.x systems (rev=1.86)
One of the possibilities to correct this is to add
imapproxyd_flags="-f ${imapproxyd_conf}"
>How-To-Repeat:
rm /etc/imapproxy.conf
create /usr/local/etc/imapproxyd.conf
reinstall port and try to start it, - it will not start.
>Fix:
Here is the patch:
--- files/imapproxyd.sh.in.orig Fri Jul 20 23:59:50 2007
+++ files/imapproxyd.sh.in.orig Tue Jul 15 18:05:07 2008
@@ -22,9 +22,11 @@
load_rc_config $name
: ${imapproxyd_enable="NO"}
: ${imapproxyd_conf="%%PREFIX%%/etc/imapproxyd.conf"}
+imapproxyd_flags="-f ${imapproxyd_conf}"
+
command=%%PREFIX%%/sbin/in.imapproxyd
required_files="${imapproxyd_conf}"
run_rc_command "$1"
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200807152226.m6FMQL6B069544>