Date: Sun, 16 Mar 2003 21:28:25 -0800 From: "Sam Leffler" <sam@errno.com> To: "Alfred Perlstein" <bright@mu.org>, <sam@freebsd.org> Cc: <imp@freebsd.org>, <current@freebsd.org> Subject: Re: wi driver Message-ID: <33c601c2ec46$0d48dce0$52557f42@errno.com> References: <20030317051920.GN4145@elvis.mu.org> <20030317052534.GO4145@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> * Alfred Perlstein <bright@mu.org> [030316 21:19] wrote:
> > um..
> >
> ...
> 840 _FLAGS_OUTRANGE) {
> 841 WI_UNLOCK(sc);
> 842 return;
> 843 }
> 844 KASSERT((ifp->if_flags & IFF_OACTIVE) == 0,
> 845 ("wi_start: if_flags %x\n", ifp->if_flags));
> 846
> 847 memset(&frmhdr, 0, sizeof(frmhdr));
>
> >
> > What's up here?
>
> It's a race, we shouldn't be inspecting the ifp without a lock.
>
> I think this kassert should be removed.
>
> Do you guys concurr?
Warner has this pending with some other fixes; perhaps he can accelerate
doing the commit? The assert is actually just bogus (if_start can be called
under certain conditions with IFF_OACTIVE set.
Sam
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?33c601c2ec46$0d48dce0$52557f42>