Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 31 Dec 2013 12:11:48 +0000 (UTC)
From:      "Alexander V. Chernikov" <melifaro@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r260124 - head/usr.bin/netstat
Message-ID:  <201312311211.rBVCBmrm076419@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: melifaro
Date: Tue Dec 31 12:11:48 2013
New Revision: 260124
URL: http://svnweb.freebsd.org/changeset/base/260124

Log:
  Explicitly free rt_tables to please Coverity.
  
  Reported by:	Coverity
  Coverity CID:	1147174
  MFC after:	2 weeks

Modified:
  head/usr.bin/netstat/route.c

Modified: head/usr.bin/netstat/route.c
==============================================================================
--- head/usr.bin/netstat/route.c	Tue Dec 31 11:54:37 2013	(r260123)
+++ head/usr.bin/netstat/route.c	Tue Dec 31 12:11:48 2013	(r260124)
@@ -426,7 +426,7 @@ p_rtable_kvm(int fibnum, int af)
 
 	if (kread((u_long)(rtree), (char *)(rt_tables) + fibnum * af_size,
 	    af_size) != 0)
-		return;
+		err(EX_OSERR, "error retrieving radix pointers");
 	for (fam = 0; fam <= AF_MAX; fam++) {
 		int tmpfib;
 
@@ -462,6 +462,8 @@ p_rtable_kvm(int fibnum, int af)
 			p_rtree_kvm(head.rnh_treetop);
 		}
 	}
+
+	free(rt_tables);
 }
 
 /*



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201312311211.rBVCBmrm076419>