Date: Mon, 2 Sep 2013 15:58:24 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Tijl Coosemans <tijl@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Mikhail Teterin <mi@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r325934 - in head/graphics/libfpx: . files Message-ID: <20130902135824.GI23033@ithaqua.etoilebsd.net> In-Reply-To: <20130902155537.593968d5@kalimero.tijl.coosemans.org> References: <201309020522.r825MxwW080249@svn.freebsd.org> <20130902155537.593968d5@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--TKDEsImF70pdVIl+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 02, 2013 at 03:55:37PM +0200, Tijl Coosemans wrote: > On Mon, 2 Sep 2013 05:22:59 +0000 (UTC) Mikhail Teterin wrote: > > Author: mi > > Date: Mon Sep 2 05:22:58 2013 > > New Revision: 325934 > > URL: http://svnweb.freebsd.org/changeset/ports/325934 > >=20 > > Log: > > Update to upstream's 1.3.1-2. Fix up the warnings raised by clang (3.= 2) and > > gcc (4.8). > > =20 > > PR: 181302 > > Submitted by: delphij@ > > Tested by: ImageMagick's self-test suit > >=20 > > Added: > > head/graphics/libfpx/files/patch-warnings (contents, props changed) > > Deleted: > > head/graphics/libfpx/files/patch-aa > > head/graphics/libfpx/files/patch-fpxlib > > head/graphics/libfpx/files/patch-ph_image > > Modified: > > head/graphics/libfpx/Makefile > > head/graphics/libfpx/distinfo > > head/graphics/libfpx/files/Makefile.bsd > >=20 > > Modified: head/graphics/libfpx/files/Makefile.bsd > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/graphics/libfpx/files/Makefile.bsd Mon Sep 2 02:57:52 2013 (r= 325933) > > +++ head/graphics/libfpx/files/Makefile.bsd Mon Sep 2 05:22:58 2013 (r= 325934) > > @@ -4,8 +4,8 @@ SHLIB_MAJOR=3D 2 > > SHLIB_MINOR=3D 7 > > WARNS=3D 3 > > =20 > > -LIBDIR =3D ${LOCALBASE}/lib > > -INCSDIR =3D ${LOCALBASE}/include > > +LIBDIR =3D ${PREFIX}/lib > > +INCSDIR =3D ${PREFIX}/include > > INCDIR =3D ${INCSDIR} # for pre-bsd.incs.mk API > > =20 > > NO_PROFILE=3D Don't want it >=20 > This makefile also adds -lstdc++ to LDADD. That's not going to work when > libstdc++ will be removed from current (soon if things go as planned). > I think the easiest would be to simply use the makefiles provided by > libfpx. It would probably even simplify the port. Just adding GNU_CONFIGURE=3Dyes and removing the manual patches and what is left behind te .include seems to just work properly. Why using a special Makefile.bsd? regards, Bapt --TKDEsImF70pdVIl+ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlIkmYAACgkQ8kTtMUmk6Ex9HgCeL3YvUIDaK0HfhlJpwDPidxA7 2PsAoJ7BQv0pGaBXtBvvgglWbJ2pkH9q =5T08 -----END PGP SIGNATURE----- --TKDEsImF70pdVIl+--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130902135824.GI23033>